[release/9.0.1xx-preview1] Fix VSTest MSBuild and Terminal Logger integration #38371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…240130.1 Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI From Version 17.10.0-preview-24078-03 -> To Version 17.10.0-preview-24080-01
dotnet-issue-labeler
bot
added
Area-DotNet Test
untriaged
nohwnd
changed the title
nohwnd
changed the title
|
@marcpopMSFT I see that some PRs are still getting into Preview1, if it is still possible to merge then please merge. I am also unsure what to do about the Darwin fail. That does not look like my mistake. |
|
@nohwnd that looks like a transient git failure, we'll rerun |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marcpopMSFT
approved these changes
Jan 30, 2024
|
Runtime is taking some additional changes so going ahead and merging this. @nohwnd you'll need a separate PR into main/8.0.3xx as we don't flow automatically |
marcpopMSFT
merged commit 029e25e
into
dotnet:release/9.0.1xx-preview1
16 checks passed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSTest added new MSBuild integration and made it the default because it wants to be consistent with terminal logger usage in commands like
dotnet build. There were 3 issues discovered during dogfooding:(summary and links to each issue and PR are here : microsoft/vstest#4843)
This PR fixes all three issues.
Risk of this fix is small, we are fixing isolated part, which has an opt-out flag. And the fixes are also simple. Setting utf8 encoding that we enforce in vstest.console anyway. And writing out message using a different msbuild api, that avoids re-parsing it.
Full diff between commits in vstest: microsoft/vstest@53df73d...d617595