-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Static web assets] Fixes issues we discovered while integrating the static web assets improvements on to the ASP.NET Core repo #19080
Merged
javiercn
merged 4 commits into
release/6.0.1xx-preview7
from
javiercn/static-web-assets-fixes
Jul 22, 2021
Merged
[Static web assets] Fixes issues we discovered while integrating the static web assets improvements on to the ASP.NET Core repo #19080
javiercn
merged 4 commits into
release/6.0.1xx-preview7
from
javiercn/static-web-assets-fixes
Jul 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
javiercn
force-pushed
the
javiercn/static-web-assets-fixes
branch
2 times, most recently
from
July 20, 2021 20:42
3f42b37
to
388a0a8
Compare
pranavkm
approved these changes
Jul 20, 2021
src/RazorSdk/Tasks/StaticWebAssets/GenerateStaticWebAssetsDevelopmentManifest.cs
Outdated
Show resolved
Hide resolved
src/RazorSdk/Tasks/StaticWebAssets/GenerateStaticWebAssetsDevelopmentManifest.cs
Outdated
Show resolved
Hide resolved
javiercn
force-pushed
the
javiercn/static-web-assets-fixes
branch
2 times, most recently
from
July 20, 2021 21:58
a3a30c4
to
459f87f
Compare
10 tasks
javiercn
force-pushed
the
javiercn/static-web-assets-fixes
branch
from
July 20, 2021 23:57
459f87f
to
a7ac919
Compare
javiercn
force-pushed
the
javiercn/static-web-assets-fixes
branch
from
July 21, 2021 07:24
a7ac919
to
745fa5d
Compare
Approved by tactics. |
javiercn
added a commit
that referenced
this pull request
Jul 24, 2021
…static web assets improvements on to the ASP.NET Core repo (#19080) * Filter doc XML files from blazor static web assets * Fallback to Identity metadata when we try to match project references * This is not technically necessary because regular projects have the right metadata, however, ASP.NET Core uses some special project types and its easy/cheap for us to be more lenient here and fallback. * Correct empty entry for manifest pattern on generation * The dotnet.js manifest file was not being passed on to GenerateBlazorBootJson manifest. * When generating the manifest we use for development we were including empty entries "" as well as the base path for assets in the current project, which is not necessary. * Only include discovery patterns when the folder exists on disk * For example, avoid creating a pattern when the wwwroot folder doesn't exist, since we can't map a non existing folder at runtime. * Correctly compute the asset path for assets that are copied to the output folder. * Fix how we deal with transitive assets
javiercn
added a commit
that referenced
this pull request
Jul 24, 2021
v-wuzhai
pushed a commit
that referenced
this pull request
Apr 22, 2024
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: JL03-Yue <59816815+JL03-Yue@users.noreply.github.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of integrating the changes we did to static web assets into the ASP.NET Core repo, we ran into some issues and this PR Contains the fixes to them.
special project types and its easy/cheap for us to be more lenient here and fallback.
in the current project, which is not necessary.
The PR is divided in three commits:
Customer Impact
Customers won't be able to load Blazor apps unless they switch to the previous Static Web Assets implementation (we included a flag for this) however, we want to make sure this is the default experience in Preview7 to ensure that we uncover as many issues as we can, since these improvements are the foundation for many of the new features we are building
Regression?
6.0 Preview6
Risk
The changes are complex, however we put a fallback mechanism in place to force the older implementation to be used. In case a scenario doesn't work for a user, they can resort to the preview6 implementation setting a value on their csproj file.
Verification
Manual verification is problematic and limited due to the fact that there is a build time component and a runtime component and that they live on different repositories.
I've been able to use a freshly built "dev sdk" to build one of the samples and i've used the runtime changes (paired with this ones) to run the project and run the published project.
Packaging changes reviewed?