Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] fix nested synchronous JS interop call detection #99296

Merged
merged 4 commits into from
Mar 6, 2024
Merged

[browser][MT] fix nested synchronous JS interop call detection #99296

merged 4 commits into from
Mar 6, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Mar 5, 2024 •
edited
Loading

  • Use current pthread ptr instead of targetContext thread ptr. It makes difference for calls from threadpool.
  • Unit test and more asserts

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Mar 5, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Mar 5, 2024
@pavelsavara pavelsavara requested a review from maraf March 5, 2024 14:43
@pavelsavara pavelsavara self-assigned this Mar 5, 2024
@ghost
Copy link

ghost commented Mar 5, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

use current pthread ptr instead of targetContext thread ptr

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

@pavelsavara pavelsavara marked this pull request as ready for review March 5, 2024 15:41
@pavelsavara pavelsavara requested a review from lewing as a code owner March 5, 2024 15:41
This was referenced Mar 5, 2024
Closed
Closed
This was referenced Mar 6, 2024
Closed
Closed
Closed
Closed
@pavelsavara
Copy link
Member Author

CI failures are known issues linked above.

@pavelsavara pavelsavara merged commit 2e1bde2 into dotnet:main Mar 6, 2024
118 of 122 checks passed
@pavelsavara pavelsavara deleted the browser_fix_sync_interop_detection branch March 6, 2024 14:20
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @maraf @jkotas