-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XUnitLogChecker: Ensure missing stack frames are resolved on Windows using dotnet-sos #98397
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f8054d3
XUnitLogChecker: Ensure missing stack frames are resolved on Windows …
carlossanlop 1d649ae
DO NOT MERGE: Testing a forced crash
carlossanlop 1d2b925
Put property in a property group, not an item group, duh
carlossanlop ee07af1
Add an additional location to _NT_SYMBOL_PATH.
carlossanlop 859e26b
Replace dump folder in _NT_SYMBOL_PATH with the shared 9.0.0 folder
carlossanlop ebc27b3
Add the PDB folder, replace the hardcoded words with property values
carlossanlop 1fa78d7
Fix escaped chars, do not use item group
carlossanlop 817280c
Revert "DO NOT MERGE: Testing a forced crash"
carlossanlop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works, LGTM. Otherwise use
%3B
to escape the ;There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoyosjs In line 255? No, in that specific case I do want to use the real behavior of
;
so that each property value gets printed in a separate line.In line 253 I did use
%3B
, as it was necessary to ensure the different values were all in the same line when setting the env var.I also made sure to escape all the
%
to%25
in 253 and 254.