Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eng/common files manually to latest without Arcade itself #97167

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

ViktorHofer
Copy link
Member

Extracting parts of #97087 out so that we can ship .NET 9 Preview 1 (NuGetAuthenticate@1 task fix).

@ViktorHofer ViktorHofer self-assigned this Jan 18, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 18, 2024
@ViktorHofer ViktorHofer added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 18, 2024
@ghost
Copy link

ghost commented Jan 18, 2024

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Extracting parts of #97087 out so that we can ship .NET 9 Preview 1 (NuGetAuthenticate@1 task fix).

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure

Milestone: -

Use version number that actually exists. The one we have in `main` doesn't.
@MichalStrehovsky
Copy link
Member

I pushed a commit to update version number from #97173 to a number that actually exists (and matches the one in the Arcade update). The one we have in main doesn't exist and official builds would still fail (they are failing due to that right now).

@ViktorHofer ViktorHofer merged commit 4068acb into main Jan 19, 2024
166 of 180 checks passed
@ViktorHofer ViktorHofer deleted the UpdateEngCommonManually branch January 19, 2024 08:10
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
…net#97167)

* Update eng/common files manually to latest without Arcade itself

* Use package version from the arcade update

Use version number that actually exists. The one we have in `main` doesn't.

---------

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants