Enable CMake Flag -W3 as New CMP0092 no Longer Does it Implicitly
#97053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMP0092 no longer adds it by default, and we use it.
|
Tagging subscribers to this area: @hoyosjs Issue DetailsResolves #96815. Starting on CMake 3.15, the warning flag
|
jkoritzinsky
requested changes
Jan 16, 2024
There was a problem hiding this comment.
We already remove the /W3 flag in eng/native/configurecompiler.cmake. We can change this PR to just remove the removal.
runtime/eng/native/configurecompiler.cmake
Lines 770 to 772 in c6966d9
ghost
added
the
needs-author-action
configuration. So no need to add another W3, just remove that removal.
ghost
removed
the
needs-author-action
jkoritzinsky
approved these changes
Jan 16, 2024
This was referenced Jan 17, 2024
Open
17 tasks
|
Failure is unrelated and is being tracked in issue #97103. Merging this now. |
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
…otnet#97053) * Add universal `-W3` option to CMakeLists.txt, as the new policy CMP0092 no longer adds it by default, and we use it. * Had not noticed there was already a W3 removal in the compilers' configuration. So no need to add another W3, just remove that removal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #96815. Starting on CMake 3.15, the warning flag
-W3is no longer added by default. We now have a minimum version of 3.20, and we would like to keep this warning enabled, so this PR addresses this.