Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce process count for ETW manifest test #96950

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Jan 14, 2024

Remove the child process test host and instead run
within the test host. Launch the ETW session
prior to launching the process - removes
the race window between ETW session spin up
and process start.

Fixes #96904

Remove the launch process and instead run
within the test host. Launch the ETW session
prior to launching the process - removes
the race window between ETW session spin up
and process start.
@ghost
Copy link

ghost commented Jan 14, 2024

Tagging subscribers to this area: @dotnet/area-system-diagnostics-tracesource
See info in area-owners.md if you want to be subscribed.

Issue Details

Remove the launch process and instead run
within the test host. Launch the ETW session
prior to launching the process - removes
the race window between ETW session spin up
and process start.

Fixes #96904

Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-System.Diagnostics.TraceSource

Milestone: 9.0.0

@ghost
Copy link

ghost commented Jan 16, 2024

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Remove the child process test host and instead run
within the test host. Launch the ETW session
prior to launching the process - removes
the race window between ETW session spin up
and process start.

Fixes #96904

Author: AaronRobinsonMSFT
Assignees: AaronRobinsonMSFT
Labels:

area-System.Diagnostics.Tracing

Milestone: 9.0.0

Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Aaron!

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit f9d7a3d into dotnet:main Jan 16, 2024
111 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the rework_etw_test branch January 16, 2024 14:23
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
* Reduce process count for ETW manifest test

Remove the launch process and instead run
within the test host. Launch the ETW session
prior to launching the process - removes
the race window between ETW session spin up
and process start.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants