Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Windows NativeAOT runtime packs #96509

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

filipnavara
Copy link
Member

@filipnavara filipnavara commented Jan 4, 2024

Contributes to #87060. These are the last missing runtime packs. We can update the list in dotnet/installer next, and switch to using PublishAotUsingRuntimePack unconditionally for .NET 9 in SDK. Then we can remove the duplicate files from ILCompiler packages.

I locally tested that it's possible to build and use win-x64 runtime pack (after it's added to the list).

@ghost
Copy link

ghost commented Jan 5, 2024

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #87060. These are the last missing runtime packs. We can update the list in dotnet/installer next, and switch to using PublishAotUsingRuntimePack unconditionally for .NET 9 in SDK. Then we can remove the duplicate files from ILCompiler packages.

I locally tested that it's possible to build and use win-x64 runtime pack (after it's added to the list).

Author: filipnavara
Assignees: -
Labels:

area-Infrastructure-installer, community-contribution, area-NativeAOT-coreclr

Milestone: -

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichalStrehovsky MichalStrehovsky merged commit dcd9ad4 into dotnet:main Jan 5, 2024
182 of 186 checks passed
@MartyIX
Copy link
Contributor

MartyIX commented Jan 5, 2024

Just out of curiosity: Is the term "runtime pack" explained somewhere?

@MichalStrehovsky
Copy link
Member

Just out of curiosity: Is the term "runtime pack" explained somewhere?

It's an implementation detail of the .NET SDK. It's a NuGet package that contains the libraries built out of this repo.

For Native AOT we currently package the libraries together with the compiler into a single NuGet and replace the coreclr-based runtime pack at publish time. This PR moves us towards not having to do this replacement.

@filipnavara filipnavara deleted the naot-runtime-pack-win branch January 5, 2024 10:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants