-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test runs to use Alpine 3.16 #95373
Conversation
Tagging subscribers to this area: @hoyosjs Issue Detailsshould fix #1423 where we fail to build packages for Helix. I also updated the base queue as Ubuntu 18.04 is EOL. We still run tests in containers but this change will allow to retire live machines running old OS.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/dotnet/core/blob/main/release-notes/8.0/supported-os.md states that we only support alpine >= 3.17. Should we 3.16 to 3.17 then?
we may. 3.16 is EOS 2024-05-23 e.g. sooner than 9.0 ships. The issue I'm trying to fix e.g. broken Helix dependencies may or may not need more work or updates. BTW Failing System.ComponentModel.Annotations tests may be related, looking into it right now. |
btw @wfurt I didn't patch 3.17 with msquic 2.2.2, only 3.15 and 3.16. I believe 3.17 already uses OpenSSL 3, so I was cautious, because I didn't know how relevant this dotnet/msquic#149 (comment) and this dotnet/msquic#151 changes are (which were already past 2.2.2) |
Right but based on the supported OS matrix, we shouldn't even test alpine3.16 on the release/8.0 branch because it isn't supported. |
It is curious, and it would give us better test coverage IMHO if we test with 3.16. I was primarily trying it to avoid another image rebuild - the failing tests are caused by the new 3.16 image. It seems like we will need some docker changes anyway so I'll probably update msquic as well. This may be tricky as we may need to go back prior their regression as well as we will need to pick up the build changes for OpenSSL 3.x. Sadly there may not be quick and easy path as I was hoping to fix failing CI. |
ok, I moved to 3.17 where possible and I left arm32 on 3.16 as fixing the underlying issue will take some time. We should be able to do that before 9.0 ships but hopefully this will help with CI test stability. |
Sounds good. Please file a tracking issue for that. |
should fix dotnet/dnceng#1423 where we fail to build packages for Helix.
I also updated the base queue as Ubuntu 18.04 is EOL. We still run tests in containers but this change will allow to retire live machines running old OS.