Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make source generated JsonTypeInfo properties nullable-oblivious #95341

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Make source generated JsonTypeInfo properties nullable-oblivious #95341

merged 1 commit into from
Nov 28, 2023

Conversation

eiriktsarpalis
Copy link
Member

Fix #95083.

@ghost ghost assigned eiriktsarpalis Nov 28, 2023
@ghost
Copy link

ghost commented Nov 28, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #95083.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Nov 28, 2023
stephentoub
stephentoub approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's no ability or need to create different contexts for different annotations of the same types, this looks like the right answer.

@eiriktsarpalis eiriktsarpalis merged commit ed6323f into dotnet:main Nov 28, 2023
106 of 109 checks passed
@eiriktsarpalis eiriktsarpalis deleted the jsontypeinfo-nullability branch November 28, 2023 18:24
This was referenced Nov 28, 2023
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@tarekgh tarekgh Awaiting requested review from tarekgh

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Passing generic class with nullable reference type in JsonSerializableAttribute raises CS8620 when used
2 participants
@eiriktsarpalis @stephentoub