Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringBuilder.Replace with ReadOnlySpan<char> #93938

Merged
merged 10 commits into from
Nov 27, 2023
Merged

StringBuilder.Replace with ReadOnlySpan<char> #93938

merged 10 commits into from
Nov 27, 2023

Commits on Oct 16, 2023

  1. StringBuilder.Replace with ReadOnlySpan<char> 

    Converted the StringBuilder.Replace(string, string, int, int) method
and underlaying methods to take ReadOnlySpan<char> as arguments
instead. The Replace methods with string arguments create spans to use
the same new method.

Fix dotnet#77837
    @TheMaximum
    TheMaximum committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    219e3fe View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Merge branch 'dotnet:main' into 77837-stringbuilder-replace-readonlyspan

    @TheMaximum
    TheMaximum committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b5a76f7 View commit details
    Browse the repository at this point in the history

  2. StringBuilder.Replace: updated null checks 

    Moved null checks to the string-specific overloads, as spans won't be
null. (PR feedback)
    @TheMaximum
    TheMaximum committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    eac03fd View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. StringBuilder.Replace: fixed PR feedback 

    Fixed code-style failure and implemented further feedback.
    @TheMaximum
    TheMaximum committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    eb5deae View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Restructured StringBuilder.Replace tests.

    Max Klaversma committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    184d74f View commit details
    Browse the repository at this point in the history

  2. Restructured StringBuilder.Replace tests (2).

    Max Klaversma committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    17acae0 View commit details
    Browse the repository at this point in the history

  3. Restructured StringBuilder.Replace tests (3).

    Max Klaversma committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b9bc86d View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Apply suggestions from code review

    @adamsitnik
    adamsitnik committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    570e380 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into 77837-stringbuilder… 

    …-replace-readonlyspan

# Conflicts:
#	src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Text/StringBuilderReplaceTests.cs
    @adamsitnik
    adamsitnik committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    acd972a View commit details
    Browse the repository at this point in the history

  3. one minor pedantic change

    @adamsitnik
    adamsitnik committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    12bbf2a View commit details
    Browse the repository at this point in the history