Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test build error when BuildAsStandalone is true #93457

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix test build error when BuildAsStandalone is true #93457

merged 1 commit into from
Oct 17, 2023

Conversation

clamp03
Copy link
Member

@clamp03 clamp03 commented Oct 13, 2023

Build error of provider.ilproj test when BuildAsStandalone is true
EXEC : error : No entry point declared for executable

This is due to #92029
Restore OutputType to Library.

@clamp03
Fix test build error when BuildAsStandalone is true
e8e2b74 
Build error of provider.ilproj test when BuildAsStandalone is true
`EXEC : error : No entry point declared for executable`

This is due to dotnet#92029
Restore OutputType to Library.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 13, 2023
@ghost
Copy link

ghost commented Oct 13, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Build error of provider.ilproj test when BuildAsStandalone is true
EXEC : error : No entry point declared for executable

This is due to #92029
Restore OutputType to Library.

Author: clamp03
Assignees: -
Labels:

area-Infrastructure-coreclr, community-contribution
Milestone: -

@clamp03 clamp03 requested a review from trylek October 13, 2023 09:43
This was referenced Oct 13, 2023
Closed
Closed
Closed
Closed
@clamp03 clamp03 closed this Oct 16, 2023
@clamp03 clamp03 reopened this Oct 16, 2023
@clamp03 clamp03 self-assigned this Oct 16, 2023
trylek
trylek approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, I'm however somewhat surprised why we need to explicitly specify the Library OutputType, I was under the impression that it's the default, why isn't the default logic kicking in here?

@clamp03
Copy link
Member Author

clamp03 commented Oct 16, 2023

Actually, I don't know well about tests in dotnet/runtime. I am just guessing that OutputType set to Exe when BuildAsStandalone is set like

runtime/src/tests/Directory.Build.props

Line 199 in 139f45e

<OutputType Condition="$(BuildAsStandalone)">Exe</OutputType>

@clamp03
Copy link
Member Author

clamp03 commented Oct 17, 2023

@trylek @jkotas I think the failures are not caused by the PR. Could you merge if it doesn't have any issue?

@jkotas jkotas merged commit b38e86d into dotnet:main Oct 17, 2023
97 of 101 checks passed
@clamp03
Copy link
Member Author

clamp03 commented Oct 17, 2023

CC @gbalykov Our internal CI fails for days because of this issue. Thank you.

gbalykov
gbalykov reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@gbalykov gbalykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbalykov
Copy link
Member

@clamp03 thank you!

@clamp03 clamp03 deleted the fix branch October 24, 2023 03:47
@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gbalykov gbalykov gbalykov left review comments

@trylek trylek trylek approved these changes

Assignees

@clamp03 clamp03

Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clamp03 @gbalykov @trylek @jkotas