Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IlasmRoundTrip tests for merged tests #93368

Merged
merged 42 commits into from
Oct 30, 2023
Merged

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Oct 11, 2023

Added a simple python script that gets generated in the merged test projects that handles roundtripping.
This also adds a very simple tool to check assemblies if they are managed and/or debug assemblies.

@ghost
Copy link

ghost commented Oct 11, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: TIHan
Assignees: TIHan
Labels:

area-Infrastructure-coreclr

Milestone: -

@TIHan
Copy link
Contributor Author

TIHan commented Oct 13, 2023

I got the roundtrips working for windows, but re-enabling the roundtrip tests, we have some failures: https://dev.azure.com/dnceng-public/public/_build/results?buildId=437210&view=ms.vss-test-web.build-test-results-tab&runId=9719900&resultId=120758&paneView=debug

I'll consider disabling these tests in roundtrips so we can move this PR forward. I'll see how bad the failures are.

@TIHan
Copy link
Contributor Author

TIHan commented Oct 19, 2023

@dotnet/jit-contrib This is ready again, see results: https://dev.azure.com/dnceng-public/public/_build/results?buildId=444219&view=results

@TIHan
Copy link
Contributor Author

TIHan commented Oct 24, 2023

@markples this is ready again. Results: https://dev.azure.com/dnceng-public/public/_build/results?buildId=449897&view=results

Definitely removing the execution test made it go a lot faster.

@markples
Copy link
Member

I'm happy seeing some of that old code go away. Thanks for the changes.

@TIHan
Copy link
Contributor Author

TIHan commented Oct 30, 2023

Failures are unrelated:

packages/microsoft.dotnet.helix.sdk/9.0.0-beta.23528.1/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(89,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item System.Net.Quic.Functional.Tests in job a618718d-2811-4c62-894a-3062e12a0589 has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/a618718d-2811-4c62-894a-3062e12a0589/workitems/System.Net.Quic.Functional.Tests/console

.packages\microsoft.dotnet.helix.sdk\9.0.0-beta.23528.1\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(42,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ConnectionPooling_Test.Http2_SmallConnectionTimeout_SubsequentRequestUsesDifferentConnection has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/497709c4-3df8-43c9-b12b-3832861e0976/workitems/System.Net.Http.Functional.Tests/console

merging

@TIHan TIHan merged commit cf9bb86 into dotnet:main Oct 30, 2023
172 of 178 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants