Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [browser][nodejs] keep runtime alive for JSExport calls #92890

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 2, 2023

Backport of #92871 to release/8.0

/cc @pavelsavara

Customer Impact

Fixed user reported #92713

Testing

Manual testing

Risk

Low, NodeJS is not official platform.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Oct 2, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92871 to release/8.0

/cc @pavelsavara

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: pavelsavara
Labels:

arch-wasm, area-VM-meta-mono, area-System.Runtime.InteropServices.JavaScript, os-browser

Milestone: -

@pavelsavara pavelsavara added this to the 8.0.0 milestone Oct 2, 2023
@pavelsavara pavelsavara added the Servicing-consider Issue for next servicing release review label Oct 2, 2023
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 3, 2023
@carlossanlop
Copy link
Member

Approved by Tactics via email.

@carlossanlop carlossanlop merged commit 8e365ee into release/8.0 Oct 3, 2023
35 of 42 checks passed
@carlossanlop carlossanlop deleted the backport/pr-92871-to-release/8.0 branch October 3, 2023 02:35
@ghost ghost locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants