-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[linux-bionic] Skip failing NTLM tests #92830
Conversation
Some NTLM tests are still running and failing even though libSystem.Net.Security.Native isn't being built for linux-bionic. This PR skips them all.
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones Issue DetailsSome NTLM tests are still running and failing even though libSystem.Net.Security.Native isn't being built for linux-bionic. This PR skips them all.
|
/azp run runtime-linuxbionic |
Azure Pipelines successfully started running 1 pipeline(s). |
should we include the managed implementation? That should just work without GSSAP AFAIK. |
Ah, yes, I think we should. |
We should but there was not any product-level check that we are running on linux-bionic. |
It is possible to test: if (RuntimeInformation.RuntimeIdentifier.StartsWith("linux-bionic")) ForBionic();
else if (RuntimeInformation.RuntimeIdentifier.StartsWith("linux-musl")) ForMusl();
else ForGlibC(); |
Hmm. I though there's a reason why the test check is implemented differently. If runtime/src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs Line 25 in 8dad137
and add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please solve the merge conflict.
I am requesting changes mostly so this PR does not show up at the next Stale PRs email ;)
For whatever reason, this doesn't appear to be failing in CI any longer. |
Some NTLM tests are still running and failing even though libSystem.Net.Security.Native isn't being built for linux-bionic. This PR skips them all.