[release/8.0] Properly handle debugger-enumerating interior pointers and enregistered refs #92360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #92313 to release/8.0 Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
hoyosjs
approved these changes
Sep 20, 2023
leculver
approved these changes
Sep 20, 2023
|
The change to It seems like the right change long term for .Net 9 though. |
hoyosjs
changed the title
hoyosjs
changed the title
tommcdon
approved these changes
Sep 20, 2023
jeffschwMSFT
approved these changes
Sep 20, 2023
hoyosjs
added
Servicing-consider
hoyosjs
force-pushed
the
backport/pr-92313-to-release/8.0
branch
from
aa578e3
to
1ac5733
Compare
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92313 to release/8.0
/cc @hoyosjs @leculver
Customer Impact
Due to a rewrite of enumeration logic, users of ICorDebug will see long standing bugs surface more often than before. Now, users would get silently incomplete heap reports as the walks are halted eagerly on errors.
Testing
Manual testing of simple scenarios. Waiting on results from more thorough testing.
Risk
Low - debugger enumeration only scenarios. Lock usage may raise the risk, but it's a reliability issue that reflect on an assert when running canonical debugger scenarios.