[wasm] Endian fix for Webcil #92274

saitama951 · 2023-09-19T13:20:50Z

'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception

The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines.

We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.

fixes #91893
cc: @omajid @iii-i @uweigand

teo-tsirpanis · 2023-09-19T17:19:09Z

src/tasks/Microsoft.NET.WebAssembly.Webcil/WebcilConverter.cs

+                virtualSize: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(sectionHeader.VirtualSize)),
+                virtualAddress: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(sectionHeader.VirtualAddress)),
+                sizeOfRawData: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(sectionHeader.SizeOfRawData)),
+                pointerToRawData: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(sectionHeader.PointerToRawData))


Suggested change

virtualSize: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(sectionHeader.VirtualSize)),

virtualAddress: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(sectionHeader.VirtualAddress)),

sizeOfRawData: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(sectionHeader.SizeOfRawData)),

pointerToRawData: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(sectionHeader.PointerToRawData))

virtualSize: BinaryPrimitives.ReverseEndianess(sectionHeader.VirtualSize),

virtualAddress: BinaryPrimitives.ReverseEndianess(sectionHeader.VirtualAddress),

sizeOfRawData: BinaryPrimitives.ReverseEndianess(sectionHeader.SizeOfRawData),

pointerToRawData: BinaryPrimitives.ReverseEndianess(sectionHeader.PointerToRawData)

teo-tsirpanis · 2023-09-19T17:20:09Z

src/tasks/Microsoft.NET.WebAssembly.Webcil/WebcilConverter.cs

+            webcilHeader.version_major = BinaryPrimitives.ReadUInt16LittleEndian(BitConverter.GetBytes( webcilHeader.version_major));
+            webcilHeader.version_minor = BinaryPrimitives.ReadUInt16LittleEndian(BitConverter.GetBytes( webcilHeader.version_minor));
+            webcilHeader.coff_sections = BinaryPrimitives.ReadUInt16LittleEndian(BitConverter.GetBytes(webcilHeader.coff_sections));
+            webcilHeader.pe_cli_header_rva = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(webcilHeader.pe_cli_header_rva));
+            webcilHeader.pe_cli_header_size = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(webcilHeader.pe_cli_header_size));
+            webcilHeader.pe_debug_rva = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(webcilHeader.pe_debug_rva));
+            webcilHeader.pe_debug_size = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(webcilHeader.pe_debug_size));


Suggested change

webcilHeader.version_major = BinaryPrimitives.ReadUInt16LittleEndian(BitConverter.GetBytes( webcilHeader.version_major));

webcilHeader.version_minor = BinaryPrimitives.ReadUInt16LittleEndian(BitConverter.GetBytes( webcilHeader.version_minor));

webcilHeader.coff_sections = BinaryPrimitives.ReadUInt16LittleEndian(BitConverter.GetBytes(webcilHeader.coff_sections));

webcilHeader.pe_cli_header_rva = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(webcilHeader.pe_cli_header_rva));

webcilHeader.pe_cli_header_size = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(webcilHeader.pe_cli_header_size));

webcilHeader.pe_debug_rva = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(webcilHeader.pe_debug_rva));

webcilHeader.pe_debug_size = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(webcilHeader.pe_debug_size));

webcilHeader.version_major = BinaryPrimitives.ReverseEndianess(webcilHeader.version_major);

webcilHeader.version_minor = BinaryPrimitives.ReverseEndianess(webcilHeader.version_minor);

webcilHeader.coff_sections = BinaryPrimitives.ReverseEndianess(webcilHeader.coff_sections);

webcilHeader.pe_cli_header_rva = BinaryPrimitives.ReverseEndianess(webcilHeader.pe_cli_header_rva);

webcilHeader.pe_cli_header_size = BinaryPrimitives.ReverseEndianess(webcilHeader.pe_cli_header_size);

webcilHeader.pe_debug_rva = BinaryPrimitives.ReverseEndianess(webcilHeader.pe_debug_rva);

webcilHeader.pe_debug_size = BinaryPrimitives.ReverseEndianess(webcilHeader.pe_debug_size);

teo-tsirpanis · 2023-09-19T17:20:58Z

src/tasks/Microsoft.NET.WebAssembly.Webcil/WebcilReader.cs

+            header.version_major = BinaryPrimitives.ReadUInt16LittleEndian(BitConverter.GetBytes(header.version_major));
+            header.version_minor = BinaryPrimitives.ReadUInt16LittleEndian(BitConverter.GetBytes(header.version_minor));
+            header.coff_sections = BinaryPrimitives.ReadUInt16LittleEndian(BitConverter.GetBytes(header.coff_sections));
+            header.pe_cli_header_rva = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(header.pe_cli_header_rva));
+            header.pe_cli_header_size = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(header.pe_cli_header_size));
+            header.pe_debug_rva = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(header.pe_debug_rva));
+            header.pe_debug_rva = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(header.pe_debug_size));


Suggested change

header.version_major = BinaryPrimitives.ReadUInt16LittleEndian(BitConverter.GetBytes(header.version_major));

header.version_minor = BinaryPrimitives.ReadUInt16LittleEndian(BitConverter.GetBytes(header.version_minor));

header.coff_sections = BinaryPrimitives.ReadUInt16LittleEndian(BitConverter.GetBytes(header.coff_sections));

header.pe_cli_header_rva = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(header.pe_cli_header_rva));

header.pe_cli_header_size = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(header.pe_cli_header_size));

header.pe_debug_rva = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(header.pe_debug_rva));

header.pe_debug_rva = BinaryPrimitives.ReadUInt32LittleEndian(BitConverter.GetBytes(header.pe_debug_size));

header.version_major = BinaryPrimitives.ReverseEndianess(header.version_major);

header.version_minor = BinaryPrimitives.ReverseEndianess(header.version_minor);

header.coff_sections = BinaryPrimitives.ReverseEndianess(header.coff_sections);

header.pe_cli_header_rva = BinaryPrimitives.ReverseEndianess(header.pe_cli_header_rva);

header.pe_cli_header_size = BinaryPrimitives.ReverseEndianess(header.pe_cli_header_size);

header.pe_debug_rva = BinaryPrimitives.ReverseEndianess(header.pe_debug_rva);

header.pe_debug_rva = BinaryPrimitives.ReverseEndianess(header.pe_debug_size);

teo-tsirpanis · 2023-09-19T17:21:34Z

src/tasks/Microsoft.NET.WebAssembly.Webcil/WebcilReader.cs

+                        virtualSize: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(secheader.VirtualSize)),
+                        virtualAddress: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(secheader.VirtualAddress)),
+                        sizeOfRawData: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(secheader.SizeOfRawData)),
+                        pointerToRawData: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(secheader.PointerToRawData))


Suggested change

virtualSize: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(secheader.VirtualSize)),

virtualAddress: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(secheader.VirtualAddress)),

sizeOfRawData: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(secheader.SizeOfRawData)),

pointerToRawData: BinaryPrimitives.ReadInt32LittleEndian(BitConverter.GetBytes(secheader.PointerToRawData))

virtualSize: BinaryPrimitives.ReverseEndianess(secheader.VirtualSize),

virtualAddress: BinaryPrimitives.ReverseEndianess(secheader.VirtualAddress),

sizeOfRawData: BinaryPrimitives.ReverseEndianess(secheader.SizeOfRawData),

pointerToRawData: BinaryPrimitives.ReverseEndianess(secheader.PointerToRawData)

teo-tsirpanis · 2023-09-19T19:21:02Z

src/tasks/Microsoft.NET.WebAssembly.Webcil/WebcilConverter.cs

        foreach (var sectionHeader in sectionsHeaders)
        {
            WriteSectionHeader(s, sectionHeader);
        }
    }

+#if NETCOREAPP2_1_OR_GREATER


Thanks. Can you try removing the #if if it compiles? This function might be available on all frameworks (unless I'm missing something).

Thanks for pointing that out. I have done the same for the WriteStructure as well and hence removing the endian checks for net472 as well. making it generic :)

It's a little more subtle than just having the API on net472. Because this code is used in an MSBuild task that might be called from a build in Visual Studio, the API has to be in whatever old version of the out of band assembly is already loaded in to the MSBuild process that invokes the task.

@saitama951 Hmm... actually we might also need to add this:

<PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />

to src/tasks/Microsoft.NET.WebAssembly.Webcil/Microsoft.NET.WebAssembly.Webcil.csproj

ghost · 2023-09-20T07:56:13Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception

The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines.

We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.

fixes #91893
cc: @omajid @iii-i @uweigand

Author:	saitama951
Assignees:	-
Labels:	`arch-wasm`, `area-Build-mono`, `community-contribution`
Milestone:	-

lambdageek

thanks!

Update Please add the PackageReference to the csproj (see #92274 (comment))

saitama951 · 2023-09-20T15:18:14Z

thanks!

Update Please add the PackageReference to the csproj (see #92274 (comment))

@lambdageek I have done the suggested changes, Thank you for the input.

radical · 2023-09-20T15:47:56Z

src/tasks/Microsoft.NET.WebAssembly.Webcil/Microsoft.NET.WebAssembly.Webcil.csproj

@@ -16,6 +16,7 @@

  <ItemGroup>
    <!-- we need to keep the version of System.Reflection.Metadata in sync with dotnet/msbuild and dotnet/sdk -->
+    <PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />  


Suggested change

<PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />

<PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />

src/tasks/Microsoft.NET.WebAssembly.Webcil/WebcilConverter.cs

'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines. We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.

saitama951 · 2023-09-21T10:41:33Z

@lambdageek @radical @teo-tsirpanis can this be merged?

radical · 2023-09-21T16:50:51Z

/azp run runtime-wasm

azure-pipelines · 2023-09-21T16:51:10Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2023-09-21T18:21:46Z

WasmBuildTests has relevant failures, like:

      [] Stack overflow.
      [] Repeat 74781 times:
      [] --------------------------------
      []    at Microsoft.NET.WebAssembly.Webcil.WebcilConverter.WriteStructure(System.IO.Stream, Microsoft.NET.WebAssembly.Webcil.WebcilHeader)
      [] --------------------------------
      []    at Microsoft.NET.WebAssembly.Webcil.WebcilConverter.WriteHeader(System.IO.Stream, Microsoft.NET.WebAssembly.Webcil.WebcilHeader)
      []    at Microsoft.NET.WebAssembly.Webcil.WebcilConverter.WriteConversionTo(System.IO.Stream, System.IO.FileStream, PEFileInfo, WCFileInfo)
      []    at Microsoft.NET.WebAssembly.Webcil.WebcilConverter.ConvertToWebcil()
      []    at Microsoft.WebAssembly.Build.Tasks.WebcilConverter.ConvertToWebcil()
      []    at Microsoft.WebAssembly.Build.Tasks.WasmAppBuilder.ExecuteInternal()
      []    at Microsoft.WebAssembly.Build.Tasks.WasmAppBuilderBaseTask.Execute()
      []    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
      []    at Microsoft.Build.BackEnd.TaskBuilder+<ExecuteInstantiatedTask>d__25.MoveNext()
      []    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.Build.BackEnd.TaskBuilder+<ExecuteInstantiatedTask>d__25, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<ExecuteInstantiatedTask>d__25 ByRef)
      []    at Microsoft.Build.BackEnd.TaskBuilder+<InitializeAndExecuteTask>d__23.MoveNext()
      []    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.Build.BackEnd.TaskBuilder+<InitializeAndExecuteTask>d__23, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<InitializeAndExecuteTask>d__23 ByRef)
      []    at Microsoft.Build.BackEnd.TaskBuilder.InitializeAndExecuteTask(Microsoft.Build.BackEnd.Logging.TaskLoggingContext, Microsoft.Build.BackEnd.ItemBucket, System.Collections.Generic.IDictionary`2<System.String,System.String>, Microsoft.Build.BackEnd.TaskHost, Microsoft.Build.BackEnd.TaskExecutionMode)
      []    at Microsoft.Build.BackEnd.TaskBuilder+<ExecuteBucket>d__19.MoveNext()
      []    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.Build.BackEnd.TaskBuilder+<ExecuteBucket>d__19, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<ExecuteBucket>d__19 ByRef)
      []    at Microsoft.Build.BackEnd.TaskBuilder+<ExecuteTask>d__18.MoveNext()
      []    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.Build.BackEnd.TaskBuilder+<ExecuteTask>d__18, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<ExecuteTask>d__18 ByRef)
      []    at Microsoft.Build.BackEnd.TaskBuilder+<ExecuteTask>d__13.MoveNext()
      []    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.Build.BackEnd.TaskBuilder+<ExecuteTask>d__13, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<ExecuteTask>d__13 ByRef)
      []    at Microsoft.Build.BackEnd.TargetEntry+<ProcessBucket>d__51.MoveNext()
      []    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.Build.BackEnd.TargetEntry+<ProcessBucket>d__51, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<ProcessBucket>d__51 ByRef)
      []    at Microsoft.Build.BackEnd.TargetEntry+<ExecuteTarget>d__44.MoveNext()
      []    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.Build.BackEnd.TargetEntry+<ExecuteTarget>d__44, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<ExecuteTarget>d__44 ByRef)
      []    at Microsoft.Build.BackEnd.TargetEntry.ExecuteTarget(Microsoft.Build.BackEnd.ITaskBuilder, Microsoft.Build.BackEnd.BuildRequestEntry, Microsoft.Build.BackEnd.Logging.ProjectLoggingContext, System.Threading.CancellationToken)
      []    at Microsoft.Build.BackEnd.TargetBuilder+<ProcessTargetStack>d__23.MoveNext()
      []    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.Build.BackEnd.TargetBuilder+<ProcessTargetStack>d__23, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<ProcessTargetStack>d__23 ByRef)
      []    at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Microsoft.Build.BackEnd.TargetBuilder+<ProcessTargetStack>d__23, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<ProcessTargetStack>d__23 ByRef)
      []    at Microsoft.Build.BackEnd.TargetBuilder.ProcessTargetStack(Microsoft.Build.BackEnd.ITaskBuilder)
      []    at Microsoft.Build.BackEnd.TargetBuilder+<BuildTargets>d__10.MoveNext()
      []    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.Build.BackEnd.TargetBuilder+<BuildTargets>d__10, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<BuildTargets>d__10 ByRef)
      []    at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.__Canon, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Start[[Microsoft.Build.BackEnd.TargetBuilder+<BuildTargets>d__10, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<BuildTargets>d__10 ByRef)
      []    at Microsoft.Build.BackEnd.TargetBuilder.BuildTargets(Microsoft.Build.BackEnd.Logging.ProjectLoggingContext, Microsoft.Build.BackEnd.BuildRequestEntry, Microsoft.Build.BackEnd.IRequestBuilderCallback, System.String[], Microsoft.Build.BackEnd.Lookup, System.Threading.CancellationToken)
      []    at Microsoft.Build.BackEnd.RequestBuilder+<BuildProject>d__68.MoveNext()
      []    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.Build.BackEnd.RequestBuilder+<BuildProject>d__68, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<BuildProject>d__68 ByRef)
      []    at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.__Canon, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Start[[Microsoft.Build.BackEnd.RequestBuilder+<BuildProject>d__68, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<BuildProject>d__68 ByRef)
      []    at Microsoft.Build.BackEnd.RequestBuilder.BuildProject()
      []    at Microsoft.Build.BackEnd.RequestBuilder+<BuildAndReport>d__59.MoveNext()
      []    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.Build.BackEnd.RequestBuilder+<BuildAndReport>d__59, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<BuildAndReport>d__59 ByRef)
      []    at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Microsoft.Build.BackEnd.RequestBuilder+<BuildAndReport>d__59, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<BuildAndReport>d__59 ByRef)
      []    at Microsoft.Build.BackEnd.RequestBuilder.BuildAndReport()
      []    at Microsoft.Build.BackEnd.RequestBuilder+<RequestThreadProc>d__58.MoveNext()
      []    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.Build.BackEnd.RequestBuilder+<RequestThreadProc>d__58, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<RequestThreadProc>d__58 ByRef)
      []    at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[Microsoft.Build.BackEnd.RequestBuilder+<RequestThreadProc>d__58, Microsoft.Build, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]](<RequestThreadProc>d__58 ByRef)
      []    at Microsoft.Build.BackEnd.RequestBuilder.RequestThreadProc(Boolean)
      []    at System.Threading.Tasks.Task`1[[System.__Canon, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].InnerInvoke()
      []    at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
      []    at System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task ByRef, System.Threading.Thread)
      []    at System.Threading.Tasks.Task.ExecuteEntry()
      []    at Microsoft.Build.BackEnd.RequestBuilder+DedicatedThreadsTaskScheduler.<InjectThread>b__6_0()
      []    at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)

lambdageek

oops

lambdageek · 2023-09-21T18:32:07Z

Moved the endianess fixup for WebcilHeader to WriteHeader instead of an overload of WriteStructure /cc @saitama951

lambdageek · 2023-09-21T19:00:08Z

/azp run runtime-wasm

azure-pipelines · 2023-09-21T19:00:18Z

Azure Pipelines successfully started running 1 pipeline(s).

uweigand · 2023-09-22T14:49:21Z

This is failing in .NET 8 - can this be merged there?

lambdageek · 2023-09-22T18:50:13Z

/backport to release/8.0

github-actions · 2023-09-22T18:50:25Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6278015202

dotnet-issue-labeler bot added the area-Build-mono label Sep 19, 2023

ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 19, 2023

saitama951 force-pushed the fix-endian-webcil branch 3 times, most recently from 2671ac0 to ab6a917 Compare September 19, 2023 16:00

teo-tsirpanis reviewed Sep 19, 2023

View reviewed changes

saitama951 force-pushed the fix-endian-webcil branch 2 times, most recently from fc4818f to 894ce35 Compare September 19, 2023 18:36

saitama951 requested a review from teo-tsirpanis September 19, 2023 18:36

This was referenced Sep 19, 2023

Build crashes in System.Runtime.Serialization.SerializationGuard #92007

Closed

MSBuild crashing in the build #92290

Open

teo-tsirpanis reviewed Sep 19, 2023

View reviewed changes

saitama951 force-pushed the fix-endian-webcil branch from 894ce35 to 5a5b543 Compare September 19, 2023 19:50

saitama951 requested a review from teo-tsirpanis September 19, 2023 19:52

This was referenced Sep 20, 2023

Tracking issue for CI build timeouts #76454

Closed

Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488

Open

maraf added the arch-wasm WebAssembly architecture label Sep 20, 2023

maraf requested a review from lambdageek September 20, 2023 07:56

maraf added this to the 9.0.0 milestone Sep 20, 2023

lambdageek approved these changes Sep 20, 2023

View reviewed changes

saitama951 force-pushed the fix-endian-webcil branch from 5a5b543 to 99df3e2 Compare September 20, 2023 15:15

radical reviewed Sep 20, 2023

View reviewed changes

src/tasks/Microsoft.NET.WebAssembly.Webcil/WebcilConverter.cs Outdated Show resolved Hide resolved

saitama951 force-pushed the fix-endian-webcil branch from 99df3e2 to 72f310a Compare September 20, 2023 16:15

saitama951 requested review from radical and lambdageek September 20, 2023 16:18

lambdageek reviewed Sep 21, 2023

View reviewed changes

Fix infinite recursion

0c78184

rename var

cecf4f0

This was referenced Sep 21, 2023

ReadsWritesClosedFinish_StreamDisposed test failures #92350

Closed

[invalid][mono] System.IO.IsolatedStorage test failures on MacCatalyst #92468

Closed

lambdageek merged commit b82b1d9 into dotnet:main Sep 22, 2023
196 of 210 checks passed

github-actions bot mentioned this pull request Sep 22, 2023

[release/8.0] [wasm] Endian fix for Webcil #92495

Merged

ghost locked as resolved and limited conversation to collaborators Oct 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm] Endian fix for Webcil #92274

[wasm] Endian fix for Webcil #92274

saitama951 commented Sep 19, 2023 •

edited

Loading

teo-tsirpanis Sep 19, 2023

teo-tsirpanis Sep 19, 2023

teo-tsirpanis Sep 19, 2023

teo-tsirpanis Sep 19, 2023

teo-tsirpanis Sep 19, 2023

saitama951 Sep 19, 2023 •

edited

Loading

lambdageek Sep 20, 2023

ghost commented Sep 20, 2023

lambdageek left a comment •

edited

Loading

saitama951 commented Sep 20, 2023

radical Sep 20, 2023

saitama951 commented Sep 21, 2023

radical commented Sep 21, 2023

azure-pipelines bot commented Sep 21, 2023

radical commented Sep 21, 2023

lambdageek left a comment

lambdageek commented Sep 21, 2023

lambdageek commented Sep 21, 2023

azure-pipelines bot commented Sep 21, 2023

uweigand commented Sep 22, 2023

lambdageek commented Sep 22, 2023

github-actions bot commented Sep 22, 2023

	<PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />
	<PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />

[wasm] Endian fix for Webcil #92274

[wasm] Endian fix for Webcil #92274

Conversation

saitama951 commented Sep 19, 2023 • edited Loading

teo-tsirpanis Sep 19, 2023

Choose a reason for hiding this comment

teo-tsirpanis Sep 19, 2023

Choose a reason for hiding this comment

teo-tsirpanis Sep 19, 2023

Choose a reason for hiding this comment

teo-tsirpanis Sep 19, 2023

Choose a reason for hiding this comment

teo-tsirpanis Sep 19, 2023

Choose a reason for hiding this comment

saitama951 Sep 19, 2023 • edited Loading

Choose a reason for hiding this comment

lambdageek Sep 20, 2023

Choose a reason for hiding this comment

ghost commented Sep 20, 2023

lambdageek left a comment • edited Loading

Choose a reason for hiding this comment

saitama951 commented Sep 20, 2023

radical Sep 20, 2023

Choose a reason for hiding this comment

saitama951 commented Sep 21, 2023

radical commented Sep 21, 2023

azure-pipelines bot commented Sep 21, 2023

radical commented Sep 21, 2023

lambdageek left a comment

Choose a reason for hiding this comment

lambdageek commented Sep 21, 2023

lambdageek commented Sep 21, 2023

azure-pipelines bot commented Sep 21, 2023

uweigand commented Sep 22, 2023

lambdageek commented Sep 22, 2023

github-actions bot commented Sep 22, 2023

saitama951 commented Sep 19, 2023 •

edited

Loading

saitama951 Sep 19, 2023 •

edited

Loading

lambdageek left a comment •

edited

Loading