Add missing System.Net.Http.Json comments #92223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContributes to #88569.
|
stephentoub
reviewed
Sep 18, 2023
...s/System.Net.Http.Json/src/System/Net/Http/Json/HttpContentJsonExtensions.AsyncEnumerable.cs
Outdated
Show resolved
Hide resolved
This was referenced Sep 18, 2023
| @@ -84,7 +84,7 @@ public static partial class HttpClientJsonExtensions | |||
| /// <param name="client">The client used to send the request.</param> | |||
| /// <param name="requestUri">The Uri the request is sent to.</param> | |||
| /// <param name="type">The type of the object to deserialize to and return.</param> | |||
| /// <param name="context">Source generated JsonSerializerContext used to control the deserialization behavior.</param> | |||
| /// <param name="context">The JsonSerializerContext used to control the deserialization behavior.</param> | |||
There was a problem hiding this comment.
Technically a JsonSerializerContext could have been manually extended by the user and not by a source generator, but I think the change is ok otherwise.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #88569.
Ported to docs in dotnet/dotnet-api-docs#9302