-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update solution files #92209
Update solution files #92209
Conversation
ca5faa3
to
c9bcaf4
Compare
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsUpdates the infrastructure to allow subfolder paths and update all solution files.
|
@@ -49,6 +59,14 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{5725D7DF-DC3 | |||
EndProject | |||
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "gen", "gen", "{55D04C80-4A8F-40AC-967D-3FA77C814D7B}" | |||
EndProject | |||
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "gen", "tools\gen", "{9C13782D-F7D7-4F02-A39D-D7BD992EB257}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why "gen", "src", and "ref" are listed twice in the sln with different paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once for the tools\...\
folder and once for the ref
, src
and gen
folders for the libraries from src/libraries that aren't grouped under the tools
folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I still don't understand why we have a gen
folder. From decoding the sln GUIDs it seems like this is for ILLink.CodeFix/ILLink.RoslynAnalyzer, so probably because of
<!-- This analyzer doesn't follow the convention for generator projects so we set the property manually. --> | |
<PropertyGroup> | |
<IsGeneratorProject>true</IsGeneratorProject> | |
</PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I see - IsGeneratorProject
is just a catch-all term for analyzers and source generators, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct
<SlnGenSolutionFolder>tools</SlnGenSolutionFolder> | ||
</PropertyGroup> | ||
|
||
</Project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add newline at EOF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Fixes #92126
Solution files in dotnet/runtime aren't buildable anymore because dependencies are missing from the graph now that a live linker is consumed. This regressed with faf883d
Updates the infrastructure to allow subfolder paths and update all solution files.