[release/8.0] Don't shut down event pipe in DLLs on Windows #92044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested a review
from MichalStrehovsky
as a code owner
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #91715 to release/8.0 Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jkotas
approved these changes
Sep 14, 2023
jeffschwMSFT
approved these changes
Sep 14, 2023
agocke
approved these changes
Sep 14, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91715 to release/8.0
/cc @MichalStrehovsky
Customer Impact
Trying to enable
EventSourceSupportin a shared library project on Native AOT currently results in a build failure since this is actively blocked in the targets. ButEventSourceSupport/event pipe mostly work, with some issues (#91762).The blocking makes it impossible for anyone to run diagnostics on their shared library. This is a regression from .NET 7, where it was at least possible to get GC ETW events in PerfView on Windows.
This changes the blocking to a suppressible warning, and fixes and issue that was causing a shutdown hang.
Testing
Manual test of dotnet trace with a shared library.
Risk
EventSourceSupportis opt in. This change allows a scenario (with a warning) that was previously forbidden. It should not affect any other codepaths. The risk is low.IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.