[release/8.0] Improve perf of ActivatorUtilities.CreateInstance() #91881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…onstructorInvoker for possible risk of callstack usage
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection Issue DetailsBackport of #91290 to release/8.0 /cc @steveharter Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
M2 approved. |
artl93
approved these changes
Sep 11, 2023
artl93
added
Servicing-approved
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91290 to release/8.0
/cc @steveharter
Customer Impact
Customers using DependencyInjection may see a significant performance regression (2-4x) to the
ActivatorUtilities.CreateInstance()API and other APIs which call it. This regression was introduced with the "keyed services" feature that added in Preview 7 due to reading attributes on members.9.0 PR: #91290
Perf issue: #91186
Testing
The existing tests are fairly thorough, but the fix added a cache that supports unloadable assemblies, so a new test was added for that. Note that assembly unloading is not supported on Mono or NativeAOT.
Risk
Low - the new cache is fairly straightforward, caching reflection-based metadata based on System.Type. Assembly unload-ability and Visual Studio hot reload have been accounted for.