[release/8.0] [iOS] Fix trimming warnings in HttpClientHandler.AnyMobile #91877
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #91520 to release/8.0 /cc @simonrozsival Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
simonrozsival
added
os-android
os-ios
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsBackport of #91520 to release/8.0 /cc @simonrozsival Customer ImpactThe code in HttpClientHandler.AnyMobile.cs produces an unactionable trimming warning when compiled with ILC. Since we are shipping NativeAOT support for iOS in .NET 8, any time customers would use TestingManually tested with RiskLow. This change is just refactoring of existing code but touches the logic that dynamically calls into Microsoft macOS/iOS/tvOS/Android and there aren't any CI tests that would catch any regressions before this change is consumed by the downstream repositories so the change can only be tested manually.
|
|
Needs M2 approval so we can add the |
ghost
locked as resolved and limited conversation to collaborators
Backport of #91520 to release/8.0
/cc @simonrozsival
Customer Impact
The code in HttpClientHandler.AnyMobile.cs produces an unactionable trimming warning when compiled with ILC. Since we are shipping NativeAOT support for iOS in .NET 8, any time customers would use
HttpClientHandlerin their apps, they would see these warnings in their build outputs.Testing
Manually tested with
xamarin/xamarin-macios.NET 8 RC1.Risk
Low. This change is just refactoring of existing code but touches the logic that dynamically calls into Microsoft macOS/iOS/tvOS/Android and there aren't any CI tests that would catch any regressions before this change is consumed by the downstream repositories so the change can only be tested manually.