Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][aot] Avoid compiling the same method multiple times during dedup. #91802

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Sep 8, 2023

No description provided.

Copy link
Member

@kotlarmilos kotlarmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Question -- Hash key is MonoMethod *method. Would the same method from two assemblies share the pointer? Probably not?

@vargaz
Copy link
Contributor Author

vargaz commented Sep 8, 2023

LGTM, thanks!

Question -- Hash key is MonoMethod *method. Would the same method from two assemblies share the pointer? Probably not?

These methods are generic instances, there is only one MonoMethod for each.

@vargaz
Copy link
Contributor Author

vargaz commented Sep 8, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
Copy link
Contributor Author

vargaz commented Sep 16, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6207700844

@ghost ghost locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants