-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasi] Work around WASI's mmap implementation not returning aligned m… #91761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
changed the title
[wasi] Work arounbd WASI's mmap implementation not returned aligned m…
[wasi] Work arounbd WASI's mmap implementation not returning aligned m…
Sep 7, 2023
…memory. Some code in sgen like sgen_los_free_object () expects the return address to be aligned. Hopefully fixes dotnet#88501 and others.
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Sep 8, 2023
vargaz
changed the title
[wasi] Work arounbd WASI's mmap implementation not returning aligned m…
[wasi] Work around WASI's mmap implementation not returning aligned m…
Sep 9, 2023
lambdageek
approved these changes
Sep 11, 2023
This was referenced Sep 11, 2023
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6185744267 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…emory.
Hopefully fixes #88501 and others.