Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasi] Work around WASI's mmap implementation not returning aligned m… #91761

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Sep 7, 2023

…emory.

Hopefully fixes #88501 and others.

@vargaz
Copy link
Contributor Author

vargaz commented Sep 7, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz changed the title [wasi] Work arounbd WASI's mmap implementation not returned aligned m… [wasi] Work arounbd WASI's mmap implementation not returning aligned m… Sep 7, 2023
…memory.

Some code in sgen like sgen_los_free_object () expects the return address to be aligned.

Hopefully fixes dotnet#88501 and others.
@vargaz
Copy link
Contributor Author

vargaz commented Sep 8, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz requested a review from lewing September 9, 2023 14:17
@vargaz vargaz changed the title [wasi] Work arounbd WASI's mmap implementation not returning aligned m… [wasi] Work around WASI's mmap implementation not returning aligned m… Sep 9, 2023
@vargaz vargaz merged commit 036c14e into dotnet:main Sep 11, 2023
42 of 45 checks passed
@vargaz vargaz deleted the wasi-mmap branch September 11, 2023 14:16
@vargaz
Copy link
Contributor Author

vargaz commented Sep 14, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6185744267

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasi] wasm trap: out of bounds memory access in sgen_gray_object_queue_trim_free_list
2 participants