Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the VN for xor operation #91503

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Fix the VN for xor operation #91503

merged 1 commit into from
Sep 3, 2023

Conversation

kunalspathak
Copy link
Member

Seems there was a typo introduced by #82190 where we were not returning ZeroVN for x ^ x operation.

Fixes: #91252

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 2, 2023
@ghost ghost assigned kunalspathak Sep 2, 2023
@ghost
Copy link

ghost commented Sep 2, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Seems there was a typo introduced by #82190 where we were not returning ZeroVN for x ^ x operation.

Fixes: #91252

Author: kunalspathak
Assignees: kunalspathak
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak
Copy link
Member Author

superpmi-* jobs are failing because the collection is not available for the guid. I have kicked off another superpmi collection run.

@kunalspathak
Copy link
Member Author

/azp run runtime-coreclr superpmi-diffs, runtime-coreclr superpmi-replay

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kunalspathak kunalspathak merged commit 6e5e512 into dotnet:main Sep 3, 2023
137 checks passed
@kunalspathak kunalspathak deleted the vn_xor branch September 3, 2023 04:19
@kunalspathak
Copy link
Member Author

/backport to release/8.0-rc2

@github-actions
Copy link
Contributor

Started backporting to release/8.0-rc2: https://github.com/dotnet/runtime/actions/runs/6253709605

@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad codegen with Vector64<int> and ^ leads to wrong output
2 participants