Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Fix Http2 MultiConnection test race conditions #91343

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 30, 2023

Backport of #91156 to release/8.0

Fixes #91075

/cc @MihaZupan

Customer Impact

Test-only change to decrease noise in CI.
On 8.0 release branches, it passes on rerun about 2x a day, failed once.

Testing

Observed CI main runs for ~2 days (and counting) without any failures (previously ~10x PassedOnRerun failures a day).

Risk

None. Test-only change.

@MihaZupan MihaZupan self-assigned this Aug 30, 2023
@MihaZupan MihaZupan added this to the 8.0.0 milestone Aug 30, 2023
@ghost
Copy link

ghost commented Aug 30, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91156 to release/8.0

/cc @MihaZupan

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: MihaZupan
Labels:

area-System.Net.Http

Milestone: 8.0.0

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since it's test-only (tell-mode).

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Aug 30, 2023
@carlossanlop carlossanlop merged commit e018fb7 into release/8.0 Aug 30, 2023
106 of 108 checks passed
@carlossanlop carlossanlop deleted the backport/pr-91156-to-release/8.0 branch August 30, 2023 19:41
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants