Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Add boolean field to indicate whether or not the Windows thread pool is being used #91246

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 28, 2023

Backport of #90551 to release/8.0

/cc @eduardo-vp

Customer Impact

This field will be used by the !threadpool SOS command to allow customers debug applications using the Windows thread pool.

Testing

The runtime correctly builds with no issues.

Risk

Very low.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 28, 2023

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90551 to release/8.0

/cc @eduardo-vp

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Threading

Milestone: -

@eduardo-vp eduardo-vp added the Servicing-consider Issue for next servicing release review label Aug 28, 2023
@eduardo-vp eduardo-vp added this to the 8.0.0 milestone Aug 28, 2023
Copy link
Member

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeffschwMSFT
Copy link
Member

@eduardo-vp is there a corresponding sos change coming to read this value?

@eduardo-vp
Copy link
Member

Yes, there's this one for the diagnostics repo dotnet/diagnostics#4160 and this one for the clrmd repo microsoft/clrmd#1175. I already tested the !threadpool command with both changes and it's working correctly. However both depend on this field being present in the runtime.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can merge when ready

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 29, 2023
@carlossanlop
Copy link
Member

Failures are:
#90605
#90834
#90639

@carlossanlop carlossanlop merged commit c755899 into release/8.0 Aug 29, 2023
166 of 175 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90551-to-release/8.0 branch August 29, 2023 23:37
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Threading Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants