[release/8.0] [mono] Handle enum return type when inlining CreateInstance #91061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Use underlying base type when deciding how to inline a CreateInstance invocation in mini_emit_inst_for_method. Fixes #90292 (Mono abort causing .NET 8 msbuild regression).
github-actions
bot
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
fanyang-mono
added
the
Servicing-consider
|
@SamMonoRT @marek-safar can we get your blessing for this change? |
|
We are waiting for @lambdageek to review when he's back next Monday. |
|
Adding blocked label - we need a further approval. |
lambdageek
approved these changes
Aug 28, 2023
|
@marek-safar @jeffschwMSFT - needs an approval for backport. It is validated. |
SamMonoRT
approved these changes
Aug 28, 2023
jeffschwMSFT
approved these changes
Aug 28, 2023
jeffschwMSFT
added
Servicing-approved
|
/cc @carlossanlop - this is ready to be merged. Thank you. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91008 to release/8.0
/cc @fanyang-mono @uweigand
Customer Impact
Mono has the logic to inline the call to System.Activator.CreateInstance(). Prior to this change, Mono always assumed
Tas non-primitive type. However, for the customer reported situation,Twas a enum type. Treating it as non-primitive type led to incorrect generated code. That triggered an assertion during runtime.Testing
The customer confirmed that with this change, the assertion went away and the generated code was correct. All CI lanes were passed as well.
Risk
Adding a new scenario that Mono wasn't considering before. Thus, the risk of breaking existing functionality is very low.