[release/8.0-rc1] [wasm] Do not build mono libs with -msimd128
#90750
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Make it optional, build only minimal set of code witch required `-msimd128` to separate library. Also provide "stub" nosimd version of this library. Choose the appropriate library during linking.
github-actions
bot
requested review from
radical,
lewing,
pavelsavara,
kg,
BrzVlad,
vargaz,
kotlarmilos,
lambdageek,
SamMonoRT and
marek-safar
as code owners
|
@lewing @radekdoulik I see some |
yup, just haven't gotten to it yet |
|
Also need a code review sign-off. Anyone here volunteers a tribute? |
|
Friendly reminder to get Tactics approval and a signoff. Today's the last day for rc1 backports. There are wasm failures. Are any of them related? |
|
Looks like some sort of test infrastructure error (a missing runtime pack?) but I've never seen it before |
|
Ok, this faiure is known and pre-existing to this PR: #88501 I opened two issues, not entirely sure if they are related to this PR or not. Need someone from wasm to help confirm it: |
carlossanlop
added
Servicing-approved
|
Approved by Tactics via email. Assuming the CI looks good, we can merge it. |
|
CI looks good to me, failed lanes weren't touched by the pr |
ghost
locked as resolved and limited conversation to collaborators
Backport of #89502 to release/8.0-rc1
Fixes the non-simd wasm target.
/cc @lewing @radekdoulik
Customer Impact
While the WASM SIMD extensions are supported across the current versions of all major browsers there are still customers that would like to support older browsers by disabling the feature and that has always been our intention. This pr fixes the Wasm build so WasmEnableSIMD=false actually produces a build that does not Require the SIMD extensions and can run successfully on older browsers.
Testing
Tested manually and in CI, the change is in main.
Risk
This only impacts the Wasm runtime build and the risk is low in that case
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.