-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't include empty prefix with EnvironmentVariablesConfigurationProvider #89612
Conversation
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsDon't include an empty prefix for Note that this is a runtime change to
|
Would that be a breaking change for any user calling |
Maybe, which is why I called it out. However, I don't know why anyone would want to parse the result of ToString. All the configuration provides override ToString for debugging. It's not in an easily parsable format. |
I understand but nobody knows. Would it make sense if we proceed with this is to file a breaking charge issue? https://github.com/dotnet/docs/issues/new?assignees=gewarren&labels=breaking-change%2CPri1%2Cdoc-idea&projects=&template=breaking-change.yml&title=%5BBreaking+change%5D%3A+ |
I don't think we'd create a breaking change issue in dotnet/aspnetcore for this level of change, but dotnet/runtime might have a different standard. It's up to you. |
@tarekgh Ok to merge? |
Don't include an empty prefix for
EnvironmentVariablesConfigurationProvider
. Makes config debug view cleaner to view:Note that this is a runtime change to
ToString
. It needs to be modified inToString
because it's used to build up the debug view string.