[7.0] Backport "Fix MSBuild integration for the host build with CMake 3.26" #88809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @hoyosjs |
jkoritzinsky
approved these changes
Jul 13, 2023
carlossanlop
commented
Jul 13, 2023
hoyosjs
approved these changes
Jul 13, 2023
This was referenced Jul 13, 2023
|
@hoyosjs @jkoritzinsky unfortunately, it didn't work. Failure is still happening: https://github.com/dotnet/runtime/pull/88809/checks?check_run_id=15001712296 |
carlossanlop
commented
Jul 13, 2023
This was referenced Jul 14, 2023
carlossanlop
merged commit 3aae244
into
dotnet:release/7.0-staging
169 of 173 checks passed
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting commit 2f20812 from this PR: #88208
From a conversation with @hoyosjs, this should fix #88806
There was other commit in the PR, but it just added a comment. Do we need it?