add test for SslClientAuthenticationOptions.ShallowClone #88557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfurt
added
area-System.Net.Security
test-enhancement
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones Issue Detailsfollow-up on #88155 and #86047 to address #88155 (comment)
|
rzikm
reviewed
Jul 10, 2023
src/libraries/Common/src/System/Net/Security/SslClientAuthenticationOptionsExtensions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 17, 2023
Comment on lines
+155
to
+166
| AllowRenegotiation = false, | ||
| AllowTlsResume = false, | ||
| ApplicationProtocols = new List<SslApplicationProtocol> { SslApplicationProtocol.Http11, SslApplicationProtocol.Http2 }, | ||
| CertificateRevocationCheckMode = X509RevocationMode.Online, | ||
| ClientCertificates = new X509CertificateCollection() { clientCert }, | ||
| EnabledSslProtocols = SslProtocols.Tls12, | ||
| EncryptionPolicy = EncryptionPolicy.RequireEncryption, | ||
| TargetHost = "foo", | ||
| CertificateChainPolicy = new X509ChainPolicy(), | ||
| RemoteCertificateValidationCallback = new RemoteCertificateValidationCallback(delegate { return true; }), | ||
| LocalCertificateSelectionCallback = new LocalCertificateSelectionCallback(delegate { return null; }), | ||
| ClientCertificateContext = SslStreamCertificateContext.Create(clientCert, null, false), |
There was a problem hiding this comment.
I assume all of these are non-default values? Might be worth a comment mentioning that.
There was a problem hiding this comment.
yes. With default value they work out of the box e.g. the test would not see if we fail to copy some value.
rzikm
approved these changes
Aug 29, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up on #88155 and #86047 to address #88155 (comment)