Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NamedPipeServerStream.Unix: GetImpersonationUserName tweaks. #88125

Merged
merged 2 commits into from
Jun 29, 2023
Merged

NamedPipeServerStream.Unix: GetImpersonationUserName tweaks. #88125

merged 2 commits into from
Jun 29, 2023

Conversation

tmds
Copy link
Member

@tmds tmds commented Jun 28, 2023

  • When the user name is not found, return an empty string like Environment.UserName.
  • Add EINTR handling.

@tmds
NamedPipeServerStream.Unix: GetImpersonationUserName tweaks.
667d992 
When the user name is not found, return an empty string like Environment.UserName.

Add EINTR handling.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 28, 2023
@ghost
Copy link

ghost commented Jun 28, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details
  • When the user name is not found, return an empty string like Environment.UserName.
  • Add EINTR handling.
Author: tmds
Assignees: -
Labels:

area-System.Net
Milestone: -

@tmds
Copy link
Member Author

tmds commented Jun 28, 2023

I've updated the PR to avoid the duplicate native functions that wrap getpwuid_r.

@build-analysis build-analysis bot mentioned this pull request Jun 28, 2023
Closed
@stephentoub stephentoub merged commit f99ebea into dotnet:main Jun 29, 2023
117 of 120 checks passed
@karelz karelz added this to the 8.0.0 milestone Jul 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@antonfirsov antonfirsov Awaiting requested review from antonfirsov

Assignees
No one assigned
Labels
area-System.Net community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tmds @stephentoub @karelz