Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of MSDia and default to using shipped versions #87782

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Jun 19, 2023

Remove allowing PATH lookup of DIA. Feature is not widely used and now we always ship a compatible version with the runtime.

@hoyosjs hoyosjs requested a review from a team June 19, 2023 20:50
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 19, 2023
@ghost ghost assigned hoyosjs Jun 19, 2023
@ghost
Copy link

ghost commented Jun 19, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Remove allowing PATH lookup of DIA. Feature is not widely used and now we always ship a compatible version with the runtime.

Author: hoyosjs
Assignees: hoyosjs
Labels:

area-Diagnostics-coreclr, needs-area-label

Milestone: -

@tommcdon tommcdon removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 19, 2023
Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hoyosjs hoyosjs merged commit 3a303b8 into dotnet:main Jun 20, 2023
177 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants