Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][debugger][MT] Make operations on dictionary thread-safe. #87405

Merged
merged 4 commits into from
Jun 13, 2023
Merged

[browser][debugger][MT] Make operations on dictionary thread-safe. #87405

merged 4 commits into from
Jun 13, 2023

Conversation

ilonatommy
Copy link
Member

Fixes #87315.

ConcurrentDictionary should be thread-safe, doc.

@ilonatommy ilonatommy self-assigned this Jun 12, 2023
@ghost
Copy link

ghost commented Jun 12, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #87315.

ConcurrentDictionary should be thread-safe, doc.

Author: ilonatommy
Assignees: ilonatommy
Labels:

area-Debugger-mono
Milestone: -

@ilonatommy ilonatommy added the arch-wasm WebAssembly architecture label Jun 12, 2023
@ghost
Copy link

ghost commented Jun 12, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #87315.

ConcurrentDictionary should be thread-safe, doc.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

CI passed but the failures are flaky so I will run again to make sure.

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy marked this pull request as ready for review June 13, 2023 06:52
maraf
maraf approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

This was referenced Jun 13, 2023
Closed
Closed
@ilonatommy @radical
Update src/mono/wasm/debugger/DebuggerTestSuite/InspectorClient.cs
295e648 
Feedback

Co-authored-by: Ankit Jain <radical@gmail.com>
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy merged commit a228f2f into dotnet:main Jun 13, 2023
@ilonatommy ilonatommy mentioned this pull request Jun 13, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@maraf maraf maraf approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

@mdh1418 mdh1418 Awaiting requested review from mdh1418

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[browser][debugger][MT] CallFunctionOnTests.RunOnInvalidCfoId
3 participants
@ilonatommy @radical @maraf