Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose AVX512 Compare and BlendVariable APIs #87404

Merged
merged 9 commits into from
Jun 19, 2023

Conversation

tannergooding
Copy link
Member

This makes progress towards #87097

@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI new-api-needs-documentation labels Jun 12, 2023
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned tannergooding Jun 12, 2023
@ghost
Copy link

ghost commented Jun 12, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This makes progress towards #87097

Author: tannergooding
Assignees: -
Labels:

area-CodeGen-coreclr, new-api-needs-documentation

Milestone: -

@tannergooding tannergooding added the avx512 Related to the AVX-512 architecture label Jun 12, 2023
@tannergooding tannergooding marked this pull request as ready for review June 14, 2023 18:37
@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib, @dotnet/avx512-contrib

This is the first of the APIs that required VectorMask under the old design and which abstract that away in lowering instead under the new design.

There should be 2-3 more PRs to finish out the public API surface for them. That will cover Gather/Scatter, Compress/Expand, and MoveMask/MaskStore/MaskLoad.

That will then finish the public API surface for the new design. There would still be further possible work, but it would be just polish/light-up in lowering to better handle the vector mask like scenarios.

@tannergooding
Copy link
Member Author

This is still ready for review, just merging in upstream since its been a couple days since CI completed.

@tannergooding tannergooding merged commit 220a03a into dotnet:main Jun 19, 2023
194 of 198 checks passed
@tannergooding tannergooding deleted the fix-87097 branch June 19, 2023 21:55
@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI avx512 Related to the AVX-512 architecture new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants