Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haiku: Configuration support #86391

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

trungnt2910
Copy link
Contributor

Added more support for configuration for Haiku cross-compile builds.

This commit adds recognition for Haiku as a supported platform in various build and configuration files.

For CMake files, this change adds additional guards for non-POSIX headers, functions, and struct members, most notably the <ucontext.h> header. (According to the latest POSIX standard, ucontext_t should be defined in <signal.h>, while <ucontext.h> is no longer mandated). -ldl is also replaced with ${CMAKE_DL_LIBS} since Haiku does not have libdl.

Part of #55803.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 17, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 17, 2023
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-config branch 3 times, most recently from 8b9fb18 to af97252 Compare May 17, 2023 16:59
@vargaz
Copy link
Contributor

vargaz commented May 17, 2023

The mono changes look ok.

@ghost
Copy link

ghost commented Jun 1, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Added more support for configuration for Haiku cross-compile builds.

This commit adds recognition for Haiku as a supported platform in various build and configuration files.

For CMake files, this change adds additional guards for non-POSIX headers, functions, and struct members, most notably the <ucontext.h> header. (According to the latest POSIX standard, ucontext_t should be defined in <signal.h>, while <ucontext.h> is no longer mandated). -ldl is also replaced with ${CMAKE_DL_LIBS} since Haiku does not have libdl.

Part of #55803.

Author: trungnt2910
Assignees: -
Labels:

area-Infrastructure-coreclr, community-contribution, os-haiku

Milestone: -

@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-config branch 5 times, most recently from 91e7d16 to 98090da Compare July 31, 2023 06:55
Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any concerns with getting this PR merged?

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The libraries changes look good to me. I would like to change the four touched projects (Net.Http, Net.NetworkInformation, Net.Security and Serialization.Formatters) in the future so that we don't have to introduce new platform TFMs.

@jkotas
Copy link
Member

jkotas commented Oct 23, 2023

@trungnt2910 Could you please resolve the conflict?

Added more support for configuration for Haiku cross-compile
builds.
@trungnt2910
Copy link
Contributor Author

@trungnt2910 Could you please resolve the conflict?

Done.

@jkotas
Copy link
Member

jkotas commented Oct 24, 2023

@trungnt2910 Thank you!

@jkotas jkotas merged commit d775a3b into dotnet:main Oct 24, 2023
186 of 189 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member os-haiku
Projects
None yet
Development

Successfully merging this pull request may close these issues.