Bugfix/30024 problem with concurrency type descriptor getconverter #85156

Maximys · 2023-04-21T10:55:06Z

This PR fix #30024 .
Problem was linked with race condition inside private method System.ComponentModel.TypeDescriptor.CheckDefaultProvider(Type).
I think, it'll better to change base type of WeakHashtable from Hashtable to ConcurrentDictionary<TKey,TValue> and use method GetOrAdd(TKey, Func<TKey,TValue>), but this changes can be very dangerous and I'm afraid to do them.

ghost · 2023-04-21T10:55:17Z

Tagging subscribers to this area: @dotnet/area-system-componentmodel
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR fix #30024 .
Problem was linked with race condition inside private method System.ComponentModel.TypeDescriptor.CheckDefaultProvider(Type).
I think, it'll better to change base type of WeakHashtable from Hashtable to ConcurrentDictionary<TKey,TValue>, but this changes can be very dangerous and I'm afraid to do them.

Author:	Maximys
Assignees:	-
Labels:	`area-System.ComponentModel`
Milestone:	-

src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs

...libraries/System.Text.RegularExpressions/gen/System.Text.RegularExpressions.Generator.csproj

src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs

src/libraries/System.ComponentModel.TypeConverter/tests/TypeDescriptionProviderTests.cs

stephentoub

At quick glance, this doesn't look like a valid change.

The NodeFor method calls CheckDefaultProvider which takes the lock on s_internalSyncObject, and AddProvider calls NodeFor while holding a lock on s_providerTable. That means while holding s_providerTable the implementation can then take a lock on s_internalSyncObject. This change, though, is extending the lock in CheckDefaultProvider such that while holding the lock on s_internalSyncObject, it calls AddProvider, which will try to take a lock on s_providerTable. That means two threads could now deadlock: one holds the lock on s_providerTable and tries to acquire the lock on s_internalSyncObject, and the other holds the lock on s_internalSyncObject and tries to acquire the lock on s_providerTable.

Maximys · 2023-05-14T02:50:57Z

@stephentoub , thanks for your comment and attention. I had fixed this problem by ReaderWriterLockSlim and made amend of my commits.

Maximys · 2023-05-22T06:18:41Z

@stephentoub ?

steveharter

The latest rebase\changes look like they address the feedback from @stephentoub.

stephentoub · 2023-06-26T16:29:43Z

The latest rebase\changes look like they address the feedback from @stephentoub.

I've not re-reviewed to determine whether there might still be the potential for deadlocks.

Also, what's the perf impact? It's now taking a reader lock on a path that wasn't previously locked.

Maximys · 2023-06-27T08:00:48Z

The latest rebase\changes look like they address the feedback from @stephentoub.

I've not re-reviewed to determine whether there might still be the potential for deadlocks.

Also, what's the perf impact? It's now taking a reader lock on a path that wasn't previously locked.

@stephentoub , could you provide some info about steps for perfomance measurement for TypeDescriptor inside current repository? I usually prefer to use BenchmarkDotNet inside console application, but I don't know how to apply this way for profiling code inside .NET Runtime.

steveharter · 2023-06-27T17:35:13Z

@stephentoub , could you provide some info about steps for perfomance measurement for TypeDescriptor inside current repository? I usually prefer to use BenchmarkDotNet inside console application, but I don't know how to apply this way for profiling code inside .NET Runtime.

We do have official benchmarks, but even those call public APIs. Would using variants of your tests with BenchmarkDotNet measure the extra read lock? If the test is very fast, you may want an inner loop within the benchmark method.

Maximys · 2023-06-28T10:41:44Z

@stephentoub , could you provide some info about steps for perfomance measurement for TypeDescriptor inside current repository? I usually prefer to use BenchmarkDotNet inside console application, but I don't know how to apply this way for profiling code inside .NET Runtime.

We do have official benchmarks, but even those call public APIs. Would using variants of your tests with BenchmarkDotNet measure the extra read lock? If the test is very fast, you may want an inner loop within the benchmark method.

I had create special branch bugfix/30024-problem-with-concurrency-typeDescriptor-getconverter(NEW), where I trying to add required tests. After that, I had build Runtime by
build.cmd clr+libs+libs.tests -rc release -lc release
as it's described here. And then I had trying to use
dotnet run -c Release -f net8.0 --filter "FullyQualifiedName=System.ComponentModel.Tests.PerformanceTests.GetConverter_ByMultithread_New" \ --corerun C:\runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe
command for run one of my tests, but output of this command is:

C:\Program Files\dotnet
C:\Program Files\dotnet\sdk\8.0.100-preview.5.23303.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1005: Assets file 'C:\runtime\artifacts\obj\tasks\project.assets.json' doesn't have a target for 'net8.0'. Ensure that restore has run and that you have included 'net8.0' in the TargetFrameworks for your project.

And I can't figure out how to fix this problem. May be somebody could explain me steps for running BenchmarkDotNet inside current repository, as I asked earlier.

Maximys · 2023-06-28T11:34:04Z

If I run already existed perfomance tests from dotnet/performance by
dotnet run -c Release -f net8.0 --filter "System.ComponentModel.Tests.Perf_TypeDescriptorTests.GetConverter" \ --corerun "C:\runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe" "C:\runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe"

command, then I receive next result:

// * Summary *

BenchmarkDotNet=v0.13.2.2052-nightly, OS=Windows 10 (10.0.19045.3086)
AMD Ryzen 5 2600, 1 CPU, 12 logical and 6 physical cores
.NET SDK=8.0.100-preview.5.23303.2
  [Host]     : .NET 8.0.0 (8.0.23.28008), X64 RyuJIT AVX2
  Job-XYPMDP : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT AVX2
  Job-FNPGHD : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT AVX2

PowerPlanMode=00000000-0000-0000-0000-000000000000  Arguments=/p:EnableUnsafeBinaryFormatterSerialization=true  IterationTime=250.0000 ms
MaxIterationCount=20  MinIterationCount=15  WarmupCount=1

|       Method |        Job |                                                                                                                Toolchain |        typeToConvert |     Mean |   Error |  StdDev |   Median |      Min |      Max | Ratio | RatioSD | Allocated | Alloc Ratio |
|------------- |----------- |------------------------------------------------------------------------------------------------------------------------- |--------------------- |---------:|--------:|--------:|---------:|---------:|---------:|------:|--------:|----------:|------------:|
| GetConverter | Job-XYPMDP |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |        ClassIDerived | 146.5 ns | 0.86 ns | 0.72 ns | 146.3 ns | 145.6 ns | 147.9 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-FNPGHD | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |        ClassIDerived | 112.6 ns | 0.30 ns | 0.28 ns | 112.6 ns | 112.2 ns | 113.1 ns |  0.77 |    0.00 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-XYPMDP |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe | ClassWithNoConverter | 147.3 ns | 0.45 ns | 0.43 ns | 147.3 ns | 146.5 ns | 148.1 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-FNPGHD | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe | ClassWithNoConverter | 111.0 ns | 0.17 ns | 0.15 ns | 111.0 ns | 110.7 ns | 111.4 ns |  0.75 |    0.00 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-XYPMDP |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |         DerivedClass | 200.3 ns | 1.90 ns | 1.78 ns | 200.4 ns | 196.9 ns | 203.4 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-FNPGHD | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |         DerivedClass | 161.5 ns | 5.24 ns | 5.82 ns | 160.1 ns | 155.6 ns | 177.6 ns |  0.81 |    0.03 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-XYPMDP |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |             IDerived | 138.1 ns | 0.27 ns | 0.25 ns | 138.0 ns | 137.8 ns | 138.5 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-FNPGHD | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |             IDerived | 102.1 ns | 0.08 ns | 0.07 ns | 102.1 ns | 102.1 ns | 102.3 ns |  0.74 |    0.00 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-XYPMDP |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |             SomeEnum | 225.1 ns | 0.80 ns | 0.74 ns | 225.3 ns | 223.8 ns | 226.1 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-FNPGHD | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |             SomeEnum | 185.4 ns | 1.26 ns | 0.98 ns | 185.2 ns | 184.4 ns | 188.0 ns |  0.82 |    0.00 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-XYPMDP |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |                 Enum | 197.6 ns | 1.10 ns | 0.97 ns | 197.4 ns | 196.2 ns | 199.9 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-FNPGHD | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |                 Enum | 163.6 ns | 4.30 ns | 4.78 ns | 164.2 ns | 155.8 ns | 170.7 ns |  0.83 |    0.02 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-XYPMDP |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |                 Guid | 203.0 ns | 3.68 ns | 3.44 ns | 204.4 ns | 195.4 ns | 209.0 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-FNPGHD | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |                 Guid | 158.9 ns | 3.07 ns | 2.87 ns | 158.0 ns | 155.8 ns | 166.4 ns |  0.78 |    0.02 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-XYPMDP |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |                Int32 | 199.0 ns | 3.99 ns | 4.60 ns | 200.4 ns | 191.5 ns | 205.8 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-FNPGHD | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |                Int32 | 156.9 ns | 2.71 ns | 2.40 ns | 156.8 ns | 153.7 ns | 162.3 ns |  0.79 |    0.02 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-XYPMDP |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |       SomeValueType? | 197.0 ns | 0.80 ns | 0.74 ns | 197.2 ns | 195.3 ns | 197.8 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-FNPGHD | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |       SomeValueType? | 161.3 ns | 3.74 ns | 4.31 ns | 160.7 ns | 154.8 ns | 168.4 ns |  0.82 |    0.02 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-XYPMDP |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |               Int32? | 207.1 ns | 5.69 ns | 6.32 ns | 206.5 ns | 196.9 ns | 220.8 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-FNPGHD | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |               Int32? | 160.0 ns | 2.75 ns | 2.57 ns | 159.9 ns | 156.3 ns | 165.0 ns |  0.77 |    0.02 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-XYPMDP |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |               String | 144.4 ns | 0.44 ns | 0.39 ns | 144.3 ns | 143.7 ns | 145.2 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-FNPGHD | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |               String | 105.9 ns | 0.09 ns | 0.08 ns | 105.9 ns | 105.8 ns | 106.0 ns |  0.73 |    0.00 |         - |          NA |

that is, performance of TypeDescriptor.GetConverter has degraded by about 20%

steveharter · 2023-06-28T14:46:05Z

that is, performance of TypeDescriptor.GetConverter has degraded by about 20%

That seems reasonable to me.

Maximys · 2023-06-30T05:14:35Z

@stephentoub , also lets look to one more branch of my repository: 30024-problem-with-concurrency-typeDescriptor-getconverter(NEW). It contains one more little optimization which provide next result:

// * Summary *

BenchmarkDotNet=v0.13.2.2052-nightly, OS=Windows 10 (10.0.19045.3155)
AMD Ryzen 5 2600, 1 CPU, 12 logical and 6 physical cores
.NET SDK=8.0.100-preview.5.23303.2
  [Host]     : .NET 8.0.0 (8.0.23.28008), X64 RyuJIT AVX2
  Job-ICGKTF : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT AVX2
  Job-LAEOHV : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT AVX2

PowerPlanMode=00000000-0000-0000-0000-000000000000  Arguments=/p:EnableUnsafeBinaryFormatterSerialization=true  IterationTime=250.0000 ms
MaxIterationCount=20  MinIterationCount=15  WarmupCount=1

|       Method |        Job |                                                                                                                Toolchain |        typeToConvert |     Mean |   Error |  StdDev |   Median |      Min |      Max | Ratio | RatioSD | Allocated | Alloc Ratio |
|------------- |----------- |------------------------------------------------------------------------------------------------------------------------- |--------------------- |---------:|--------:|--------:|---------:|---------:|---------:|------:|--------:|----------:|------------:|
| GetConverter | Job-ICGKTF |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |        ClassIDerived | 123.7 ns | 0.41 ns | 0.34 ns | 123.6 ns | 123.4 ns | 124.6 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-LAEOHV | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |        ClassIDerived | 109.3 ns | 0.08 ns | 0.06 ns | 109.4 ns | 109.2 ns | 109.5 ns |  0.88 |    0.00 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-ICGKTF |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe | ClassWithNoConverter | 125.5 ns | 0.33 ns | 0.31 ns | 125.5 ns | 124.8 ns | 125.9 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-LAEOHV | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe | ClassWithNoConverter | 112.4 ns | 0.24 ns | 0.21 ns | 112.4 ns | 111.8 ns | 112.6 ns |  0.90 |    0.00 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-ICGKTF |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |         DerivedClass | 184.7 ns | 1.69 ns | 1.50 ns | 184.2 ns | 182.6 ns | 187.5 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-LAEOHV | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |         DerivedClass | 161.5 ns | 1.68 ns | 1.57 ns | 160.9 ns | 159.4 ns | 164.5 ns |  0.88 |    0.01 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-ICGKTF |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |             IDerived | 119.7 ns | 0.51 ns | 0.47 ns | 119.7 ns | 118.8 ns | 120.4 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-LAEOHV | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |             IDerived | 102.3 ns | 0.07 ns | 0.06 ns | 102.3 ns | 102.1 ns | 102.4 ns |  0.85 |    0.00 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-ICGKTF |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |             SomeEnum | 204.4 ns | 0.52 ns | 0.48 ns | 204.4 ns | 203.3 ns | 205.0 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-LAEOHV | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |             SomeEnum | 183.8 ns | 0.20 ns | 0.17 ns | 183.8 ns | 183.3 ns | 184.0 ns |  0.90 |    0.00 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-ICGKTF |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |                 Enum | 183.8 ns | 1.75 ns | 1.64 ns | 184.4 ns | 180.3 ns | 186.0 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-LAEOHV | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |                 Enum | 162.6 ns | 2.01 ns | 1.88 ns | 162.3 ns | 159.9 ns | 166.3 ns |  0.88 |    0.01 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-ICGKTF |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |                 Guid | 185.3 ns | 0.85 ns | 0.79 ns | 185.5 ns | 183.2 ns | 186.1 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-LAEOHV | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |                 Guid | 162.5 ns | 0.90 ns | 0.85 ns | 162.7 ns | 159.9 ns | 163.4 ns |  0.88 |    0.00 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-ICGKTF |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |                Int32 | 181.4 ns | 1.72 ns | 1.61 ns | 181.8 ns | 178.5 ns | 183.6 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-LAEOHV | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |                Int32 | 161.1 ns | 1.30 ns | 1.22 ns | 160.9 ns | 158.7 ns | 162.7 ns |  0.89 |    0.01 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-ICGKTF |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |       SomeValueType? | 179.8 ns | 2.63 ns | 2.46 ns | 180.2 ns | 175.7 ns | 183.4 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-LAEOHV | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |       SomeValueType? | 160.5 ns | 2.12 ns | 1.98 ns | 160.3 ns | 157.5 ns | 163.9 ns |  0.89 |    0.02 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-ICGKTF |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |               Int32? | 179.4 ns | 2.73 ns | 2.55 ns | 179.5 ns | 175.8 ns | 184.2 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-LAEOHV | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |               Int32? | 157.7 ns | 1.77 ns | 1.65 ns | 157.1 ns | 155.4 ns | 160.5 ns |  0.88 |    0.01 |         - |          NA |
|              |            |                                                                                                                          |                      |          |         |         |          |          |          |       |         |           |             |
| GetConverter | Job-ICGKTF |                \runtime\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |               String | 124.0 ns | 0.49 ns | 0.46 ns | 124.2 ns | 123.5 ns | 124.6 ns |  1.00 |    0.00 |         - |          NA |
| GetConverter | Job-LAEOHV | \runtime_without_my_fix\artifacts\bin\testhost\net8.0-windows-Release-x64\shared\Microsoft.NETCore.App\8.0.0\CoreRun.exe |               String | 109.4 ns | 0.06 ns | 0.05 ns | 109.4 ns | 109.3 ns | 109.4 ns |  0.88 |    0.00 |         - |          NA |

As you can see, perfomance degradation has decreased to 10% after commit 92a2d245958ce41e05398580c0ea45419e05effe. May be it's ok? What do you think?

src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs

steveharter · 2023-08-07T15:13:55Z

@stephentoub - PTAL again thanks

steveharter · 2023-08-09T17:26:51Z

Closing this PR for v8 due to risk + schedule; ideally should be done early in the 9.0 branch. There is risk in this PR and we need more time to verify this than what we have left in v8 -- RC1 is almost done.

@Maximys thanks for this PR.

cc @JeremyKuhne - thoughts on fixing this? This issue also occurs in .NET Framework to my knowledge.

dotnet-issue-labeler bot added the area-System.ComponentModel label Apr 21, 2023

ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 21, 2023

Maximys force-pushed the bugfix/30024-problem-with-concurrency-typeDescriptor-getconverter branch from f3e9d88 to 4693f40 Compare April 21, 2023 11:05

steveharter requested a review from stephentoub April 26, 2023 19:40

steveharter reviewed Apr 26, 2023

View reviewed changes

src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs Outdated Show resolved Hide resolved

This was referenced May 2, 2023

Failures in System.Net.Mail.Tests.SmtpClientTest tests #85637

Closed

System.IO.Tests.RandomAccess_NoBuffering.ReadUsingSingleBuffer timing out #85659

Closed

steveharter reviewed May 4, 2023

View reviewed changes

...libraries/System.Text.RegularExpressions/gen/System.Text.RegularExpressions.Generator.csproj Outdated Show resolved Hide resolved

Maximys force-pushed the bugfix/30024-problem-with-concurrency-typeDescriptor-getconverter branch from 0f46857 to e9e137e Compare May 5, 2023 06:48

stephentoub reviewed May 6, 2023

View reviewed changes

src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs Outdated Show resolved Hide resolved

stephentoub reviewed May 6, 2023

View reviewed changes

src/libraries/System.ComponentModel.TypeConverter/tests/TypeDescriptionProviderTests.cs Outdated Show resolved Hide resolved

stephentoub requested changes May 6, 2023

View reviewed changes

This comment was marked as duplicate.

Sign in to view

ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label May 6, 2023

Maximys force-pushed the bugfix/30024-problem-with-concurrency-typeDescriptor-getconverter branch from e9e137e to 92254ef Compare May 13, 2023 16:48

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label May 13, 2023

ericstj requested review from stephentoub and steveharter June 22, 2023 17:31

steveharter approved these changes Jun 26, 2023

View reviewed changes

steveharter requested a review from buyaa-n July 5, 2023 17:19

steveharter reviewed Jul 12, 2023

View reviewed changes

src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs Outdated Show resolved Hide resolved

Maksim Golev and others added 5 commits August 4, 2023 08:22

fix(30024): Fix problem with concurrency of TypeDescriptor.

6360220

fix(30024): Little performance improvements.

7d1336d

fix(30024): One more performance improvements.

12c9c82

fix(30024): Switching to iterating over array.

5f80bd5

fix(30024): Removing needless loop.

1f20655

Maximys force-pushed the bugfix/30024-problem-with-concurrency-typeDescriptor-getconverter branch from 92254ef to 1f20655 Compare August 4, 2023 04:25

steveharter reviewed Aug 4, 2023

View reviewed changes

Maksim Golev added 2 commits August 7, 2023 10:35

refactor(30024): Simplifying value declarations.

f912fda

refactor(30024): Changing "GetCustomAttributes" to "GetCustomAttribute".

f7deebe

steveharter self-requested a review August 7, 2023 15:11

steveharter approved these changes Aug 7, 2023

View reviewed changes

steveharter closed this Aug 9, 2023

ghost locked as resolved and limited conversation to collaborators Sep 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix/30024 problem with concurrency type descriptor getconverter #85156

Bugfix/30024 problem with concurrency type descriptor getconverter #85156

Maximys commented Apr 21, 2023 •

edited

Loading

ghost commented Apr 21, 2023

stephentoub left a comment

This comment was marked as duplicate.

Maximys commented May 14, 2023

Maximys commented May 22, 2023

steveharter left a comment

stephentoub commented Jun 26, 2023

Maximys commented Jun 27, 2023

steveharter commented Jun 27, 2023

Maximys commented Jun 28, 2023

Maximys commented Jun 28, 2023

steveharter commented Jun 28, 2023

Maximys commented Jun 30, 2023

steveharter commented Aug 7, 2023

steveharter commented Aug 9, 2023

Bugfix/30024 problem with concurrency type descriptor getconverter #85156

Bugfix/30024 problem with concurrency type descriptor getconverter #85156

Conversation

Maximys commented Apr 21, 2023 • edited Loading

ghost commented Apr 21, 2023

stephentoub left a comment

Choose a reason for hiding this comment

This comment was marked as duplicate.

Maximys commented May 14, 2023

Maximys commented May 22, 2023

steveharter left a comment

Choose a reason for hiding this comment

stephentoub commented Jun 26, 2023

Maximys commented Jun 27, 2023

steveharter commented Jun 27, 2023

Maximys commented Jun 28, 2023

Maximys commented Jun 28, 2023

steveharter commented Jun 28, 2023

Maximys commented Jun 30, 2023

steveharter commented Aug 7, 2023

steveharter commented Aug 9, 2023

Maximys commented Apr 21, 2023 •

edited

Loading