Handle crash when [out] parameter of type int is passed to delegate #81276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giritrivedi
requested review from
vargaz,
lambdageek and
thaystg
as code owners
ghost
added
the
community-contribution
When a delegate is passed an [out] parameter of type "int" it will crash since this data type is not handled in emit_managed_wrapper_ilgen. This will lead to a crash. With this fix [out] parameter of type "int" is handled after adding an addition case statement to handle MONO_TYPE_I in emit_managed_wrapper_ilgen. Supporting UT is added.
giritrivedi
force-pushed
the
out_int_para_fix
branch
from
72ff98a
to
b9a43ce
Compare
vargaz
approved these changes
Feb 7, 2023
|
@lambdageek , @thaystg can you review this plz ? |
|
Thanks for your contribution @giritrivedi 🎉 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a delegate is passed an [out] parameter of type "int" it will crash since this data type is not handled in emit_managed_wrapper_ilgen. This will lead to a crash. With this fix [out] parameter of type "int" is handled after adding an addition case statement to handle MONO_TYPE_I in emit_managed_wrapper_ilgen. Supporting UT is added.