Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Change TrimMode setting for templates, and tests #80639

Merged
merged 4 commits into from
Jan 17, 2023
Merged

[wasm] Change TrimMode setting for templates, and tests #80639

merged 4 commits into from
Jan 17, 2023

Conversation

radical
Copy link
Member

@radical radical commented Jan 14, 2023 •
edited
Loading

  • Don't set TrimMode=partial for all wasm apps. This would make the wasm templates default to TrimMode=full.
  • And set TrimMode=partial for library tests

@ghost ghost assigned radical Jan 14, 2023
lewing
lewing reviewed Jan 14, 2023
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably remove

runtime/src/mono/wasm/build/WasmApp.props

Line 7 in ec5fffb

<TrimMode Condition="'$(TrimMode)' == ''">partial</TrimMode>
and set it explicitly for the libraries tests. We might need to set it to partial for targets < 8.0 though

@radical radical changed the title [wasm] Set TrimMode=full for templates [wasm] Change TrimMode setting for templates, and tests Jan 14, 2023
@radical
Copy link
Member Author

radical commented Jan 14, 2023 •
edited
Loading

We might need to set it to partial for targets < 8.0 though

That should be the case for 7.0 branches right now.

@build-analysis build-analysis bot mentioned this pull request Jan 15, 2023
Closed
@runfoapp runfoapp bot mentioned this pull request Jan 16, 2023
Closed
@radical radical requested a review from lewing January 17, 2023 16:55
@radical
Copy link
Member Author

radical commented Jan 17, 2023

The coreclr failures are unrelated - #80679 .

@radical radical merged commit 63f46d2 into dotnet:main Jan 17, 2023
@radical radical deleted the misc-fixes branch January 17, 2023 21:28
@ghost ghost locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

Assignees

@radical radical

Labels
area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @lewing