Set FieldSeq in CreateSpan for field handle #80622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsFixes this codegen: int ConstRva()
{
ReadOnlySpan<int> RVA = new [] { 1, 2, 3, 4, 5 };
return RVA[3];
}to produce "return 4". Because previously PTAL @SingleAccretion @jakobbotsch @dotnet/jit-contrib
|
SingleAccretion
approved these changes
Jan 13, 2023
| GenTree* pointerValue = gtNewIconHandleNode((size_t)data, GTF_ICON_CONST_PTR); | ||
| GenTree* lengthValue = gtNewIconNode(count, TYP_INT); | ||
| FieldSeq* fldSeq = | ||
| GetFieldSeqStore()->Create(fieldToken, (ssize_t)data, FieldSeq::FieldKind::SimpleStaticKnownAddress); |
There was a problem hiding this comment.
It's not "really" SimpleStaticKnownAddress in the non-runtime (aka NAOT) case, but I don't think that's a big problem as long as we don't assume this address dereferenceable in the Jit (which we don't).
jakobbotsch
approved these changes
Jan 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this codegen:
to produce "return 4".
Because previously
CreateSpanintrisnsic (that Roslyn emits for this syntax) didn't properly propagate FieldSeq for the field so the corresponding VN optimization wasn't able to fold RVA[const] (it only worked for bytes where CreateSpan is not emitted).PTAL @SingleAccretion @jakobbotsch @dotnet/jit-contrib