Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instances of %S #78894

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/coreclr/debug/ee/controller.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2168,7 +2168,7 @@ void DebuggerController::RemovePatchesFromModule(Module *pModule, AppDomain *pAp
}
CONTRACTL_END;

LOG((LF_CORDB, LL_INFO100000, "DPT::CPFM mod:0x%p (%S)\n",
LOG((LF_CORDB, LL_INFO100000, "DPT::CPFM mod:0x%p (%s)\n",
pModule, pModule->GetDebugName()));

// First find all patches of interest
Expand Down Expand Up @@ -7398,14 +7398,14 @@ void DebuggerStepper::TriggerMethodEnter(Thread * thread,
"See http://team/sites/clrdev/Devdocs/StubManagers.rtf for more information on StubManagers.\n"
"Stepper this=0x%p, startMethod='%s::%s'\n"
"---------------------------------\n"
"Stub manager log:\n%S"
"Stub manager log:\n%s"
"\n"
"The thread is now in managed method '%s::%s'.\n"
"---------------------------------\n",
this,
((m_StepInStartMethod == NULL) ? "unknown" : m_StepInStartMethod->m_pszDebugClassName),
((m_StepInStartMethod == NULL) ? "unknown" : m_StepInStartMethod->m_pszDebugMethodName),
sLog.GetUnicode(),
sLog.GetUTF8(),
pDesc->m_pszDebugClassName, pDesc->m_pszDebugMethodName
));
}
Expand Down Expand Up @@ -8707,8 +8707,8 @@ DebuggerEnCBreakpoint::DebuggerEnCBreakpoint(SIZE_T offset,
_ASSERTE( jitInfo != NULL );
// Add and activate the specified patch
AddBindAndActivateNativeManagedPatch(jitInfo->m_nativeCodeVersion.GetMethodDesc(), jitInfo, offset, LEAF_MOST_FRAME, pAppDomain);
LOG((LF_ENC,LL_INFO1000, "DEnCBPDEnCBP::adding %S patch!\n",
fTriggerType == REMAP_PENDING ? W("remap pending") : W("remap complete")));
LOG((LF_ENC,LL_INFO1000, "DEnCBPDEnCBP::adding %s patch!\n",
fTriggerType == REMAP_PENDING ? "remap pending" : "remap complete"));
}


Expand Down Expand Up @@ -8749,9 +8749,9 @@ TP_RESULT DebuggerEnCBreakpoint::TriggerPatch(DebuggerControllerPatch *patch,
_ASSERTE(map == MAPPING_EXACT);

LOG((LF_ENC, LL_ALWAYS,
"DEnCBP::TP: triggered E&C %S breakpoint: tid=0x%x, module=0x%08x, "
"DEnCBP::TP: triggered E&C %s breakpoint: tid=0x%x, module=0x%08x, "
"method def=0x%08x, version=%d, native offset=0x%x, IL offset=0x%x\n this=0x%x\n",
m_fTriggerType == REMAP_PENDING ? W("ResumePending") : W("ResumeComplete"),
m_fTriggerType == REMAP_PENDING ? "ResumePending" : "ResumeComplete",
thread, module, md, m_jitInfo->m_encVersion, offset, currentIP, this));

// If this is a REMAP_COMPLETE patch, then dispatch the RemapComplete callback
Expand Down
14 changes: 7 additions & 7 deletions src/coreclr/debug/ee/debugger.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9335,7 +9335,7 @@ void Debugger::LoadAssembly(DomainAssembly * pDomainAssembly)
if (CORDBUnrecoverableError(this))
return;

LOG((LF_CORDB, LL_INFO100, "D::LA: Load Assembly Asy:0x%p AD:0x%p which:%ls\n",
LOG((LF_CORDB, LL_INFO100, "D::LA: Load Assembly Asy:0x%p AD:0x%p which:%s\n",
pDomainAssembly, pDomainAssembly->GetAppDomain(), pDomainAssembly->GetAssembly()->GetDebugName() ));

if (!CORDebuggerAttached())
Expand Down Expand Up @@ -9391,7 +9391,7 @@ void Debugger::UnloadAssembly(DomainAssembly * pDomainAssembly)
if (CORDBUnrecoverableError(this))
return;

LOG((LF_CORDB, LL_INFO100, "D::UA: Unload Assembly Asy:0x%p AD:0x%p which:%ls\n",
LOG((LF_CORDB, LL_INFO100, "D::UA: Unload Assembly Asy:0x%p AD:0x%p which:%s\n",
pDomainAssembly, pDomainAssembly->GetAppDomain(), pDomainAssembly->GetAssembly()->GetDebugName() ));

Thread *thread = g_pEEInterface->GetThread();
Expand Down Expand Up @@ -9676,7 +9676,7 @@ void Debugger::UnloadModule(Module* pRuntimeModule,



LOG((LF_CORDB, LL_INFO100, "D::UM: unload module Mod:%#08x AD:%#08x runtimeMod:%#08x modName:%ls\n",
LOG((LF_CORDB, LL_INFO100, "D::UM: unload module Mod:%#08x AD:%#08x runtimeMod:%#08x modName:%s\n",
LookupOrCreateModule(pRuntimeModule, pAppDomain), pAppDomain, pRuntimeModule, pRuntimeModule->GetDebugName()));


Expand All @@ -9689,7 +9689,7 @@ void Debugger::UnloadModule(Module* pRuntimeModule,
DebuggerModule* module = LookupOrCreateModule(pRuntimeModule, pAppDomain);
if (module == NULL)
{
LOG((LF_CORDB, LL_INFO100, "D::UM: module already unloaded AD:%#08x runtimeMod:%#08x modName:%ls\n",
LOG((LF_CORDB, LL_INFO100, "D::UM: module already unloaded AD:%#08x runtimeMod:%#08x modName:%s\n",
pAppDomain, pRuntimeModule, pRuntimeModule->GetDebugName()));
goto LExit;
}
Expand Down Expand Up @@ -9776,7 +9776,7 @@ void Debugger::DestructModule(Module *pModule)
}
CONTRACTL_END;

LOG((LF_CORDB, LL_INFO100, "D::DM: destruct module runtimeMod:%#08x modName:%ls\n",
LOG((LF_CORDB, LL_INFO100, "D::DM: destruct module runtimeMod:%#08x modName:%s\n",
pModule, pModule->GetDebugName()));

// @@@
Expand Down Expand Up @@ -10002,7 +10002,7 @@ BOOL Debugger::LoadClass(TypeHandle th,
// handle this in SendSystemClassLoadUnloadEvent below by looping through all AppDomains and dispatching
// events for each that contain this assembly.

LOG((LF_CORDB, LL_INFO10000, "D::LC: load class Tok:%#08x Mod:%#08x AD:%#08x classMod:%#08x modName:%ls\n",
LOG((LF_CORDB, LL_INFO10000, "D::LC: load class Tok:%#08x Mod:%#08x AD:%#08x classMod:%#08x modName:%s\n",
classMetadataToken, (pAppDomain == NULL) ? NULL : LookupOrCreateModule(classModule, pAppDomain),
pAppDomain, classModule, classModule->GetDebugName()));

Expand Down Expand Up @@ -10057,7 +10057,7 @@ void Debugger::UnloadClass(mdTypeDef classMetadataToken,
return;
}

LOG((LF_CORDB, LL_INFO10000, "D::UC: unload class Tok:0x%08x Mod:%#08x AD:%#08x runtimeMod:%#08x modName:%ls\n",
LOG((LF_CORDB, LL_INFO10000, "D::UC: unload class Tok:0x%08x Mod:%#08x AD:%#08x runtimeMod:%#08x modName:%s\n",
classMetadataToken, LookupOrCreateModule(classModule, pAppDomain), pAppDomain, classModule, classModule->GetDebugName()));

Assembly *pAssembly = classModule->GetClassLoader()->GetAssembly();
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/debug/ee/functioninfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2266,7 +2266,7 @@ void DebuggerMethodInfoTable::ClearMethodsOfModule(Module *pModule)

_ASSERTE(g_pDebugger->HasDebuggerDataLock());

LOG((LF_CORDB, LL_INFO1000000, "CMOM:mod:0x%x (%S)\n", pModule
LOG((LF_CORDB, LL_INFO1000000, "CMOM:mod:0x%x (%s)\n", pModule
,pModule->GetDebugName()));

HASHFIND info;
Expand Down
4 changes: 0 additions & 4 deletions src/coreclr/inc/ceesectionstring.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ class CeeSectionString : public CeeSection {
StringTableEntry *findStringInsert(
StringTableEntry *&entry, _In_z_ LPWSTR targetValue, ULONG hashId);
void deleteEntries(StringTableEntry *e);
#ifdef RDATA_STATS
int dumpEntries(StringTableEntry *e);
void dumpTable();
#endif

public:
~CeeSectionString();
Expand Down
29 changes: 0 additions & 29 deletions src/coreclr/md/ceefilegen/ceesectionstring.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,37 +28,8 @@ void CeeSectionString::deleteEntries(StringTableEntry *e)
delete e;
}

#ifdef RDATA_STATS
int CeeSectionString::dumpEntries(StringTableEntry *e)
{
if (!e)
return 0;
else {
printf(" HashId: %d, value: %S\n", e->m_hashId, computOffset(e->m_offset));
return dumpEntries(e->m_next) + 1;
}
}

void CeeSectionString::dumpTable()
{
int sum = 0, count = 0;
for (int i=0; i < MaxRealEntries; i++) {
if (stringTable[i]) {
printf("Bucket %d\n", i);
printf("Total size: %d\n\n",
count = dumpEntries(stringTable[i]));
sum += count;
}
}
printf("Total number strings: %d\n\n", sum);
}
#endif

CeeSectionString::~CeeSectionString()
{
#ifdef RDATA_STATS
dumpTable();
#endif
for (int i=0; i < MaxRealEntries; i++)
deleteEntries(stringTable[i]);
}
Expand Down
16 changes: 8 additions & 8 deletions src/coreclr/md/compiler/emit.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ STDMETHODIMP RegMeta::DefineMethod( // S_OK or error.
LPUTF8 szNameUtf8;
UTF8STR(szName, szNameUtf8);

LOG((LOGMD, "MD: RegMeta::DefineMethod(0x%08x, %S, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x)\n",
td, MDSTR(szName), dwMethodFlags, pvSigBlob, cbSigBlob, ulCodeRVA, dwImplFlags, pmd));
LOG((LOGMD, "MD: RegMeta::DefineMethod(0x%08x, %s, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x)\n",
td, szNameUtf8, dwMethodFlags, pvSigBlob, cbSigBlob, ulCodeRVA, dwImplFlags, pmd));

LOCKWRITE();

Expand Down Expand Up @@ -477,8 +477,8 @@ STDMETHODIMP RegMeta::DefineMemberRef( // S_OK or error
LPUTF8 szNameUtf8;
UTF8STR(szName, szNameUtf8);

LOG((LOGMD, "MD RegMeta::DefineMemberRef(0x%08x, %S, 0x%08x, 0x%08x, 0x%08x)\n",
tkImport, MDSTR(szName), pvSigBlob, cbSigBlob, pmr));
LOG((LOGMD, "MD RegMeta::DefineMemberRef(0x%08x, %s, 0x%08x, 0x%08x, 0x%08x)\n",
tkImport, szNameUtf8, pvSigBlob, cbSigBlob, pmr));
LOCKWRITE();

IfFailGo(m_pStgdb->m_MiniMd.PreUpdate());
Expand Down Expand Up @@ -2618,8 +2618,8 @@ HRESULT RegMeta::DefineField( // S_OK or error.
LPUTF8 szNameUtf8;
UTF8STR(szName, szNameUtf8);

LOG((LOGMD, "MD: RegMeta::DefineField(0x%08x, %S, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x)\n",
td, MDSTR(szName), dwFieldFlags, pvSigBlob, cbSigBlob, dwCPlusTypeFlag, pValue, cchValue, pmd));
LOG((LOGMD, "MD: RegMeta::DefineField(0x%08x, %s, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x)\n",
td, szNameUtf8, dwFieldFlags, pvSigBlob, cbSigBlob, dwCPlusTypeFlag, pValue, cchValue, pmd));

LOCKWRITE();

Expand Down Expand Up @@ -2739,8 +2739,8 @@ HRESULT RegMeta::DefineProperty(
LPUTF8 szUTF8Property;
UTF8STR(szProperty, szUTF8Property);

LOG((LOGMD, "MD RegMeta::DefineProperty(0x%08x, %S, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x)\n",
td, szProperty, dwPropFlags, pvSig, cbSig, dwCPlusTypeFlag, pValue, cchValue, mdSetter, mdGetter,
LOG((LOGMD, "MD RegMeta::DefineProperty(0x%08x, %s, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x)\n",
td, szUTF8Property, dwPropFlags, pvSig, cbSig, dwCPlusTypeFlag, pValue, cchValue, mdSetter, mdGetter,
rmdOtherMethods, pmdProp));

LOCKWRITE();
Expand Down
20 changes: 10 additions & 10 deletions src/coreclr/md/compiler/import.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ STDMETHODIMP RegMeta::EnumMembersWithName( // S_OK, S_FALSE, or error.
UTF8STR(szName, szNameUtf8);
LPCUTF8 szNameUtf8Tmp;

LOG((LOGMD, "MD RegMeta::EnumMembersWithName(0x%08x, 0x%08x, %S, 0x%08x, 0x%08x, 0x%08x)\n",
phEnum, cl, MDSTR(szName), rMembers, cMax, pcTokens));
LOG((LOGMD, "MD RegMeta::EnumMembersWithName(0x%08x, 0x%08x, %s, 0x%08x, 0x%08x, 0x%08x)\n",
phEnum, cl, szNameUtf8, rMembers, cMax, pcTokens));

LOCKREAD();

Expand Down Expand Up @@ -333,8 +333,8 @@ STDMETHODIMP RegMeta::EnumMethodsWithName( // S_OK, S_FALSE, or error.
UTF8STR(szName, szNameUtf8);
LPCUTF8 szNameUtf8Tmp;

LOG((LOGMD, "MD RegMeta::EnumMethodsWithName(0x%08x, 0x%08x, %S, 0x%08x, 0x%08x, 0x%08x)\n",
phEnum, cl, MDSTR(szName), rMethods, cMax, pcTokens));
LOG((LOGMD, "MD RegMeta::EnumMethodsWithName(0x%08x, 0x%08x, %s, 0x%08x, 0x%08x, 0x%08x)\n",
phEnum, cl, szNameUtf8, rMethods, cMax, pcTokens));

LOCKREAD();

Expand Down Expand Up @@ -518,8 +518,8 @@ STDMETHODIMP RegMeta::EnumFieldsWithName( // S_OK, S_FALSE, or error.
UTF8STR(szName, szNameUtf8);
LPCUTF8 szNameUtf8Tmp;

LOG((LOGMD, "MD RegMeta::EnumFields(0x%08x, 0x%08x, %S, 0x%08x, 0x%08x, 0x%08x)\n",
phEnum, cl, MDSTR(szName), rFields, cMax, pcTokens));
LOG((LOGMD, "MD RegMeta::EnumFields(0x%08x, 0x%08x, %s, 0x%08x, 0x%08x, 0x%08x)\n",
phEnum, cl, szNameUtf8, rFields, cMax, pcTokens));



Expand Down Expand Up @@ -965,8 +965,8 @@ STDMETHODIMP RegMeta::FindMethod(
LPUTF8 szNameUtf8;
UTF8STR(szName, szNameUtf8);

LOG((LOGMD, "MD RegMeta::FindMethod(0x%08x, %S, 0x%08x, 0x%08x, 0x%08x)\n",
td, MDSTR(szName), pvSigBlob, cbSigBlob, pmb));
LOG((LOGMD, "MD RegMeta::FindMethod(0x%08x, %s, 0x%08x, 0x%08x, 0x%08x)\n",
td, szNameUtf8, pvSigBlob, cbSigBlob, pmb));

LOCKREAD();

Expand Down Expand Up @@ -1047,8 +1047,8 @@ STDMETHODIMP RegMeta::FindMemberRef(
LPUTF8 szNameUtf8;
UTF8STR(szName, szNameUtf8);

LOG((LOGMD, "MD RegMeta::FindMemberRef(0x%08x, %S, 0x%08x, 0x%08x, 0x%08x)\n",
tkPar, MDSTR(szName), pvSigBlob, cbSigBlob, pmr));
LOG((LOGMD, "MD RegMeta::FindMemberRef(0x%08x, %s, 0x%08x, 0x%08x, 0x%08x)\n",
tkPar, MDSTRA(szNameUtf8), pvSigBlob, cbSigBlob, pmr));
AaronRobinsonMSFT marked this conversation as resolved.
Show resolved Hide resolved

// <TODO>@todo: Can this causing building hash table? If so, should this consider the write lock?</TODO>
LOCKREAD();
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/vm/assembly.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ class Assembly
PTR_LoaderAllocator GetLoaderAllocator() { LIMITED_METHOD_DAC_CONTRACT; return m_pLoaderAllocator; }

#ifdef LOGGING
LPCWSTR GetDebugName()
LPCUTF8 GetDebugName()
{
WRAPPER_NO_CONTRACT;
return GetPEAssembly()->GetDebugName();
Expand Down
10 changes: 5 additions & 5 deletions src/coreclr/vm/ceeload.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ void Module::Initialize(AllocMemTracker *pamTracker, LPCWSTR szName)
}
#endif // defined (PROFILING_SUPPORTED) &&!defined(DACCESS_COMPILE)

LOG((LF_CLASSLOADER, LL_INFO10, "Loaded pModule: \"%ws\".\n", GetDebugName()));
LOG((LF_CLASSLOADER, LL_INFO10, "Loaded pModule: \"%s\".\n", GetDebugName()));
}

#endif // DACCESS_COMPILE
Expand Down Expand Up @@ -1772,7 +1772,7 @@ void Module::SetDomainAssembly(DomainAssembly *pDomainAssembly)

SIZE_T size = GetDomainLocalModuleSize();

LOG((LF_CLASSLOADER, LL_INFO10, "STATICS: Allocating %i bytes for precomputed statics in module %S in LoaderAllocator %p\n",
LOG((LF_CLASSLOADER, LL_INFO10, "STATICS: Allocating %zi bytes for precomputed statics in module %s in LoaderAllocator %p\n",
size, this->GetDebugName(), pLoaderAllocator));

// We guarantee alignment for 64-bit regular statics on 32-bit platforms even without FEATURE_64BIT_ALIGNMENT for performance reasons.
Expand Down Expand Up @@ -2389,12 +2389,12 @@ ISymUnmanagedReader *Module::GetISymUnmanagedReader(void)
if (SUCCEEDED(hr))
{
m_pISymUnmanagedReader = pReader.Extract();
LOG((LF_CORDB, LL_INFO10, "M::GISUR: Loaded symbols for module %S\n", GetDebugName()));
LOG((LF_CORDB, LL_INFO10, "M::GISUR: Loaded symbols for module %s\n", GetDebugName()));
}
else
{
// We failed to create the reader, don't try again next time
LOG((LF_CORDB, LL_INFO10, "M::GISUR: Failed to load symbols for module %S\n", GetDebugName()));
LOG((LF_CORDB, LL_INFO10, "M::GISUR: Failed to load symbols for module %s\n", GetDebugName()));
_ASSERTE( m_pISymUnmanagedReader == k_pInvalidSymReader );
}

Expand Down Expand Up @@ -2464,7 +2464,7 @@ void Module::SetSymbolBytes(LPCBYTE pbSyms, DWORD cbSyms)
_ASSERTE( m_pISymUnmanagedReader == NULL );

#ifdef LOGGING
LPCWSTR pName = NULL;
LPCUTF8 pName = NULL;
pName = GetDebugName();
#endif // LOGGING

Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/vm/ceeload.h
Original file line number Diff line number Diff line change
Expand Up @@ -1502,7 +1502,7 @@ class Module : public ModuleBase
const SString &GetPath() { WRAPPER_NO_CONTRACT; return m_pPEAssembly->GetPath(); }

#ifdef LOGGING
LPCWSTR GetDebugName() { WRAPPER_NO_CONTRACT; return m_pPEAssembly->GetDebugName(); }
LPCUTF8 GetDebugName() { WRAPPER_NO_CONTRACT; return m_pPEAssembly->GetDebugName(); }
#endif

PEImageLayout * GetReadyToRunImage();
Expand Down
6 changes: 3 additions & 3 deletions src/coreclr/vm/clsload.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1302,7 +1302,7 @@ BOOL ClassLoader::FindClassModuleThrowing(
LPCUTF8 szName = pName->GetName();
if (szName == NULL)
szName = "<UNKNOWN>";
LOG((LF_CLASSLOADER, LL_INFO10, "Failed to find type \"%s\", assembly \"%ws\" in hash table. Incomplete = %d\n",
LOG((LF_CLASSLOADER, LL_INFO10, "Failed to find type \"%s\", assembly \"%s\" in hash table. Incomplete = %d\n",
szName, GetAssembly()->GetDebugName(), incomplete));
#endif
return FALSE;
Expand Down Expand Up @@ -2866,7 +2866,7 @@ TypeHandle ClassLoader::DoIncrementalLoad(TypeKey *pTypeKey, TypeHandle typeHnd,
{
SString name;
TypeString::AppendTypeKeyDebug(name, pTypeKey);
LOG((LF_CLASSLOADER, LL_INFO10000, "PHASEDLOAD: About to do incremental load of type %S (%p) from level %s\n", name.GetUnicode(), typeHnd.AsPtr(), classLoadLevelName[currentLevel]));
LOG((LF_CLASSLOADER, LL_INFO10000, "PHASEDLOAD: About to do incremental load of type %s (%p) from level %s\n", name.GetUTF8(), typeHnd.AsPtr(), classLoadLevelName[currentLevel]));
}
#endif

Expand Down Expand Up @@ -3261,7 +3261,7 @@ TypeHandle ClassLoader::LoadTypeHandleForTypeKey(TypeKey *pTypeKey,
{
SString name;
TypeString::AppendTypeKeyDebug(name, pTypeKey);
LOG((LF_CLASSLOADER, LL_INFO10000, "PHASEDLOAD: LoadTypeHandleForTypeKey for type %S to level %s\n", name.GetUnicode(), classLoadLevelName[targetLevel]));
LOG((LF_CLASSLOADER, LL_INFO10000, "PHASEDLOAD: LoadTypeHandleForTypeKey for type %s to level %s\n", name.GetUTF8(), classLoadLevelName[targetLevel]));
CrstHolder unresolvedClassLockHolder(&m_UnresolvedClassLock);
m_pUnresolvedClassHash->Dump();
}
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/vm/domainassembly.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,7 @@ void DomainAssembly::SetupDebuggingConfig(void)

SetDebuggerInfoBits((DebuggerAssemblyControlFlags)dacfFlags);

LOG((LF_CORDB, LL_INFO10, "Assembly %S: bits=0x%x\n", GetDebugName(), GetDebuggerInfoBits()));
LOG((LF_CORDB, LL_INFO10, "Assembly %s: bits=0x%x\n", GetDebugName(), GetDebuggerInfoBits()));
#endif // DEBUGGING_SUPPORTED
}

Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/vm/domainassembly.h
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class DomainAssembly final
}

#ifdef LOGGING
LPCWSTR GetDebugName()
LPCUTF8 GetDebugName()
{
WRAPPER_NO_CONTRACT;
return GetPEAssembly()->GetDebugName();
Expand Down
5 changes: 3 additions & 2 deletions src/coreclr/vm/excep.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4040,11 +4040,12 @@ BuildCreateDumpCommandLine(
}
}

commandLine.AppendASCII(DumpGeneratorName);
commandLine.AppendUTF8(DumpGeneratorName);

if (dumpName != nullptr)
{
commandLine.AppendPrintf(" --name %S", dumpName);
commandLine.AppendUTF8(" --name ");
commandLine.Append(dumpName);
}

const char* dumpTypeOption = nullptr;
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/vm/methodtablebuilder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1355,7 +1355,7 @@ MethodTableBuilder::BuildMethodTableThrowing(
pszDebugName = (LPCUTF8)name;
}

LOG((LF_CLASSLOADER, LL_INFO1000, "Loading class \"%s%s%s\" from module \"%ws\" in domain 0x%p %s\n",
LOG((LF_CLASSLOADER, LL_INFO1000, "Loading class \"%s%s%s\" from module \"%s\" in domain 0x%p %s\n",
*pszDebugNamespace ? pszDebugNamespace : "",
*pszDebugNamespace ? NAMESPACE_SEPARATOR_STR : "",
debugName.GetUTF8(),
Expand Down
Loading