Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running WebAssembly Browser App from VS #75384

Merged
merged 13 commits into from
Sep 14, 2022
Merged

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Sep 10, 2022

As $(OutputPath) is not absolute path, we need to add $(MSBuildProjectDirectory)

Tested:

  • Create a new WebAssembly Browser App on VS and run, change WasmAppDir and run again.
  • Create a new WebAssembly Console App on VS and run, change WasmAppDir and run again.
  • Create a new wasmbrowser app using command line and run;
  • Create a new wasmconsole app using command line and run;
  • Create a new wasmbrowser app using command line and dotnet build and dotnet run --no-build;
  • Create a new wasmbrowser app using command line and dotnet build and dotnet run --debug;

Also, added tests for command line runs. But a few of the tests are disabled because the tests would be using 7.0 targets, but 7.0 doesn't have the fix yet.

Fix #75356

@ghost
Copy link

ghost commented Sep 10, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

As $(OutputPath) is not absolute path, we need to add $(MSBuildProjectDirectory)

Fix #75356

Author: thaystg
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@radical radical added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) arch-wasm WebAssembly architecture area-Build-mono and removed area-Infrastructure-mono labels Sep 11, 2022
@ghost
Copy link

ghost commented Sep 11, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

As $(OutputPath) is not absolute path, we need to add $(MSBuildProjectDirectory)

Fix #75356

Author: thaystg
Assignees: thaystg
Labels:

NO-MERGE, arch-wasm, area-Build-mono

Milestone: -

@radical radical removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 12, 2022
@radical
Copy link
Member

radical commented Sep 13, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3042387685

.. which is failing because the WBT is still using net7.0 on `main`,
thus using the 7.0 targets, which don't have the fix yet.

We can enable this once the fix is merged for 7.0 .
@radical
Copy link
Member

radical commented Sep 13, 2022

The corresponding 7.0 PR has been merged. Once the packages from that are available, the disabled test here can be enabled again.

@lewing
Copy link
Member

lewing commented Sep 14, 2022

failure is #74302

@lewing lewing merged commit b55b256 into dotnet:main Sep 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run WebAssembly Browser App from VS or CLI
3 participants