Skip Quic IPv6 tests on unsupported platforms #75341
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue Detailsnull
|
|
btw 16.04 is old and way out of support. We should move to 18.04 or 20.04 base OS. |
|
Does the base OS matter when running in a container? |
|
yes, somewhat. It will share Linux kernel and interface auto-configuration and bridging is also done by the host AFAIK. |
|
I see, can we simply change the base OS when updating the Helix image reference? |
|
yes. You can then look at the console and see if tests were skipped or not. (or Kusto if we store such info) |
|
Are you sure the I think what was intended was: using Socket s = new Socket(AddressFamily.InterNetworkV6, SocketType.Dgram, ProtocolType.Udp);Note the |
In dotnet#75341, some QUIC tests were changed to only run when IPv6 is supported. IPv6 was detected by binding a socket. However the socket was bound with an invalid combination of `SocketType.Dgram` and `ProtocolType.Tcp`. On macOS, this fails with the exception: ``` System.Net.Sockets.SocketException (41): Protocol wrong type for socket ``` See the docs for listing of which combinations are valid to use together: https://docs.microsoft.com/dotnet/api/system.net.sockets.sockettype Since QUIC uses UDP, I think the intention was to bind a UDP socket.
In #75341, some QUIC tests were changed to only run when IPv6 is supported. IPv6 was detected by binding a socket. However the socket was bound with an invalid combination of `SocketType.Dgram` and `ProtocolType.Tcp`. On macOS, this fails with the exception: ``` System.Net.Sockets.SocketException (41): Protocol wrong type for socket ``` See the docs for listing of which combinations are valid to use together: https://docs.microsoft.com/dotnet/api/system.net.sockets.sockettype Since QUIC uses UDP, I think the intention was to bind a UDP socket.
ghost
locked as resolved and limited conversation to collaborators
This PR skips tests using IPv6 addresses on platforms where it would lead to EADDRNOTAVAIL errors.