Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [wasm] Test, and app host fixes #75295

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 8, 2022

Backport of #74512 to release/7.0

/cc @thaystg @radical

Customer Impact

After creating a wasmbrowser app, when trying to run on windows, the user gets this error:
The application to execute does not exist: 'C:\Program'

Testing

Manually validated

Risk

Low risk, only adding the quotes.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@thaystg thaystg added the Servicing-consider Issue for next servicing release review label Sep 8, 2022
@carlossanlop carlossanlop removed the Servicing-consider Issue for next servicing release review label Sep 9, 2022
@carlossanlop
Copy link
Member

The servicing-consider label is not needed for backports until after we snap on Tuesday.
Right now we only need an approval from @marek-safar.

@thaystg is the WASM Firefox CI failure related to this change? They may be #75018 and #75013 but I'd rather get your help to confirm. cc @radical

Callstack
  Failed DebuggerTests.EvaluateOnCallFrameTests.InheritedAndPrivateMembersInAClass(prefix: "this.") [53 s]
  Error Message:
   System.Threading.Tasks.TaskCanceledException : A task was canceled.
  Stack Trace:
     at DebuggerTests.DebuggerTestFirefox.EvaluateOnCallFrame(String id, String expression, Boolean expect_ok) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestFirefox.cs:line 430
   at DebuggerTests.DebuggerTestBase.EvaluateOnCallFrameAndCheck(String call_frame_id, ValueTuple`2[] args) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 1166
   at DebuggerTests.EvaluateOnCallFrameTests.<>c__DisplayClass9_0.<<InheritedAndPrivateMembersInAClass>b__0>d.MoveNext() in /_/src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs:line 235
--- End of stack trace from previous location ---
   at DebuggerTests.DebuggerTestBase.CheckInspectLocalsAtBreakpointSite(String type, String method, Int32 line_offset, String bp_function_name, String eval_expression, Func`2 locals_fn, Func`2 wait_for_event_fn, Boolean use_cfo, String assembly, Int32 col) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 299
   at DebuggerTests.EvaluateOnCallFrameTests.InheritedAndPrivateMembersInAClass(String prefix) in /_/src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs:line 225
--- End of stack trace from previous location ---
[xUnit.net 00:12:15.53]     DebuggerTests.EvaluateOnCallFrameTests.InheritedAndPrivateMembersInAClass(prefix: "this.") [FAIL]
[xUnit.net 00:13:15.54]     DebuggerTests.EvaluateOnCallFrameTests.InheritedAndPrivateMembersInAClass(prefix: "") [FAIL]
  Failed DebuggerTests.EvaluateOnCallFrameTests.InheritedAndPrivateMembersInAClass(prefix: "") [54 s]
  Error Message:
   System.Threading.Tasks.TaskCanceledException : A task was canceled.
  Stack Trace:
     at DebuggerTests.DebuggerTestFirefox.EvaluateOnCallFrame(String id, String expression, Boolean expect_ok) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestFirefox.cs:line 430
   at DebuggerTests.DebuggerTestBase.EvaluateOnCallFrameAndCheck(String call_frame_id, ValueTuple`2[] args) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 1166
   at DebuggerTests.EvaluateOnCallFrameTests.<>c__DisplayClass9_0.<<InheritedAndPrivateMembersInAClass>b__0>d.MoveNext() in /_/src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs:line 235
--- End of stack trace from previous location ---
   at DebuggerTests.DebuggerTestBase.CheckInspectLocalsAtBreakpointSite(String type, String method, Int32 line_offset, String bp_function_name, String eval_expression, Func`2 locals_fn, Func`2 wait_for_event_fn, Boolean use_cfo, String assembly, Int32 col) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 299
   at DebuggerTests.EvaluateOnCallFrameTests.InheritedAndPrivateMembersInAClass(String prefix) in /_/src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs:line 225

The other CI failures don't seem related to this PR. They are:

@thaystg
Copy link
Member

thaystg commented Sep 9, 2022

is the WASM Firefox CI failure related to this change?

No. They are flaky tests that I'm working to fix.

@radical
Copy link
Member

radical commented Sep 9, 2022

@carlossanlop Failures are unrelated.

@carlossanlop
Copy link
Member

Ok thanks. Only thing left is @marek-safar approval.

@carlossanlop
Copy link
Member

Talked with @lewing offline. I can consider this approved for merging.

@carlossanlop carlossanlop merged commit fcb841c into release/7.0 Sep 9, 2022
@carlossanlop carlossanlop deleted the backport/pr-74512-to-release/7.0 branch September 9, 2022 19:10
@jamesmontemagno
Copy link
Member

@carlossanlop @lewing was this in RC 1?

@carlossanlop
Copy link
Member

@ghost ghost locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants