Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Update dependencies from dotnet/emsdk #74926

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 1, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/emsdk

  • Subscription: 68df92bc-29da-47e1-6f60-08da7ef6374d
  • Build: 20220901.4
  • Date Produced: September 1, 2022 12:53:36 PM UTC
  • Commit: f0b0035bb362fd964d1c2e53d7ba8e973f660b09
  • Branch: refs/heads/release/7.0

…01.4

Microsoft.NET.Workload.Emscripten.net6.Manifest-7.0.100 , Microsoft.NET.Workload.Emscripten.net7.Manifest-7.0.100
 From Version 7.0.0-rc.2.22430.5 -> To Version 7.0.0-rc.2.22451.4
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Sep 1, 2022
@carlossanlop
Copy link
Member

The CI was down yesterday for maintenance. Only 10 checks were executed while that happened. I'm closing and reopening this PR so the full CI runs.

@carlossanlop
Copy link
Member

@radical @lewing I opened issues for all the WASM related failures I found in this PR. Since this is an emscripten update, can you please help determine if this dependency update is the cause of those failures? If it is not, then please let me know if I can merge it.

@radical
Copy link
Member

radical commented Sep 3, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Sep 3, 2022

@carlossanlop The debugger test failures are with firefox which are known to be unstable. You can ignore those. And the library test failure seems to be helix miscommunication? The log shows that the tests passed.

I kicked off runtime-wasm to run the AOT tests, but the emsdk side changes don't seem to be relevant. So, this is good to go from wasm pov.

@carlossanlop carlossanlop merged commit b8fed32 into release/7.0 Sep 6, 2022
@carlossanlop carlossanlop deleted the darc-release/7.0-d8c6eb7b-6281-488d-a1ee-3afdb04d7f58 branch September 6, 2022 18:31
@ghost ghost locked as resolved and limited conversation to collaborators Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants