Fix possible stack overflow in HttpListener #74644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue Detailsnull
|
rzikm
added a commit
to dotnet/dotnet-api-docs
that referenced
this pull request
Aug 26, 2022
This reflects fixes from dotnet/runtime#74644
MihaZupan
approved these changes
Aug 26, 2022
|
I see that there is a similar problem inside Rewriting the |
wfurt
approved these changes
Aug 26, 2022
I was unable to trigger the stack overflow using my local program, so I don't trying to convert it to a test would be useful. |
|
Test failure is #74795 |
rzikm
added a commit
to dotnet/dotnet-api-docs
that referenced
this pull request
Aug 30, 2022
* Update AsyncSockerServer to fix possible StackOverflow This reflects fixes from dotnet/runtime#74644 * Fix compilation * Update AsyncSocketServer.cs * Update snippets/csharp/System.Net.Sockets/SocketAsyncEventArgs/Overview/AsyncSocketServer.cs Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73674.
This PR replaces mutual recursion between
AcceptandProcessAcceptby a loop inAccept, which avoids infinite recursion.