Remove wrong cgroups assert #72372
Merged
Remove wrong cgroups assert #72372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When detecting the current cgroup version on Linux, checked and debug builds assert when the filesystem type of /sys/fs/cgroup is neither TMPFS_MAGIC nor CGROUP2_SUPER_MAGIC. This change removes the assert and considers it as "no cgroup support". Release builds already have this behavior. Close dotnet#62960
stephentoub
approved these changes
Jul 18, 2022
jkotas
approved these changes
Jul 18, 2022
|
Could you also fix up the third fork of this file here? |
|
Ah, I have forgotten that nativeaot had one too. |
|
@dotnet/dnceng The test legs finished running already, but the build analysis shows a page saying that once the tests complete, the analysis will be there. Is that a known issue? I have restarted a leg before, so it might be related. |
|
@janvorli Build analysis suffered an outage that was fixed around 3:10 PM PT. As far as I understand, the analysis will be lost for builds completed while the outage was ongoing. |
|
There are two libraries tests that keep failing on Windows in the legs of this CI. I've tried to restart the tests, but they still failed. Since my change is in purely Unix code, I'm merging it. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When detecting the current cgroup version on Linux, checked and
debug builds assert when the filesystem type of /sys/fs/cgroup is
neither TMPFS_MAGIC nor CGROUP2_SUPER_MAGIC. This change removes
the assert and considers it as "no cgroup support". This is the case
e.g. in chroot environment.
Release builds already have this behavior.
Close #62960