Always use live host #71725
Always use live host #71725
Conversation
Eliminates package dependency on the host during build and test.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsEliminates package dependency on the host during build and test.
|
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.props
Show resolved
Hide resolved
--- a/eng/native/configuretools.cmake
+++ b/eng/native/configuretools.cmake
@@ -29,6 +29,7 @@ if(NOT WIN32 AND NOT CLR_CMAKE_TARGET_BROWSER)
endif()
find_program(EXEC_LOCATION_${exec}
+ NO_CACHE
NAMES
"${TOOLSET_PREFIX}${exec}${CLR_CMAKE_COMPILER_FILE_NAME_VERSION}"
"${TOOLSET_PREFIX}${exec}")fixes the build. "Building with older llvm" was fixed in #71742 but I forgot about this OOTB caching mechanism of cmake. :) |
Unblocks #71725. Followup: #71742 Prior to #71742, we were calling `locate_toolchain_exec` once per tool. Calling it twice with different prefix gives us the old result, which is something we don't want (we only call this local function a few times in this file, and each time for intention to "lookup" the executable).
|
@am11 Thanks! |
|
Ah, We would need the old way of evicting the cached result. 😁 --- a/eng/native/configuretools.cmake
+++ b/eng/native/configuretools.cmake
@@ -28,8 +28,8 @@ if(NOT WIN32 AND NOT CLR_CMAKE_TARGET_BROWSER)
return()
endif()
+ unset(EXEC_LOCATION_${exec} CACHE)
find_program(EXEC_LOCATION_${exec}
- NO_CACHE
NAMES
"${TOOLSET_PREFIX}${exec}${CLR_CMAKE_COMPILER_FILE_NAME_VERSION}"
"${TOOLSET_PREFIX}${exec}")tested with cmake 3.10. @agocke, if this PR is targeting 7.0, could you please apply this patch here. Otherwise I can open a new PR for this. Thanks! |
|
Happy to apply it here. |
|
linux-musl failure is because the host machine is Ubuntu and build is running directly on the host rather than inside Alpine container. |
This reverts commit 63692cd.
ghost
locked as resolved and limited conversation to collaborators
Eliminates package dependency on the host during build and test.