Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should return the error when there is one #71585

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

cshung
Copy link
Member

@cshung cshung commented Jul 2, 2022

In case we fail to read some virtual memory (e.g. in this case), we should fail the API call.

@ghost
Copy link

ghost commented Jul 2, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

In case we fail to read some virtual memory (e.g. in this case), we should fail the API call.

Author: cshung
Assignees: cshung
Labels:

area-Diagnostics-coreclr

Milestone: -

@AaronRobinsonMSFT
Copy link
Member

Failure is #70969

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit f54ec72 into dotnet:main Jul 2, 2022
@cshung cshung deleted the public/fail-when-error branch July 2, 2022 23:22
@ghost ghost locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants